From owner-svn-src-all@FreeBSD.ORG Fri May 11 20:37:50 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 042CA106566B for ; Fri, 11 May 2012 20:37:50 +0000 (UTC) (envelope-from bounces+73574-8822-svn-src-all=freebsd.org@sendgrid.me) Received: from o3.shared.sendgrid.net (o3.shared.sendgrid.net [208.117.48.85]) by mx1.freebsd.org (Postfix) with SMTP id 7F5D98FC0A for ; Fri, 11 May 2012 20:37:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.info; h= message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; s=smtpapi; bh=TmySVd5pe/UddOiZl38fL3byYow=; b=XbNxvvaudptOL6ZryNArdmwem+FD W8o8s2K0JLAJJBuJzXeLrinJjljl9CXSfLHH1G72gaNv8tjs/GkmZNRU8qAGx5oT yLstiEJLllpube57mO2XHCLP1kGCDN8Kjfo/skyAw6nfhEIvclrcg3r8ViIhi7ox 7vTToLHImPORPBc= Received: by 10.36.109.142 with SMTP id mf35.8210.4FAD78975 Fri, 11 May 2012 15:37:43 -0500 (CDT) Received: from mail.tarsnap.com (unknown [10.9.180.5]) by mi12 (SG) with ESMTP id 4fad7897.7eba.356fef for ; Fri, 11 May 2012 15:37:43 -0500 (CST) Received: (qmail 27272 invoked from network); 11 May 2012 20:31:00 -0000 Received: from unknown (HELO clamshell.daemonology.net) (127.0.0.1) by mail.tarsnap.com with ESMTP; 11 May 2012 20:31:00 -0000 Received: (qmail 2790 invoked from network); 11 May 2012 20:37:06 -0000 Received: from unknown (HELO clamshell.daemonology.net) (127.0.0.1) by clamshell.daemonology.net with SMTP; 11 May 2012 20:37:06 -0000 Message-ID: <4FAD7872.7030503@freebsd.org> Date: Fri, 11 May 2012 13:37:06 -0700 From: Colin Percival User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:12.0) Gecko/20120509 Thunderbird/12.0.1 MIME-Version: 1.0 To: Warner Losh References: <201205111237.q4BCbGX2083596@svn.freebsd.org> <20120511124820.GN2358@deviant.kiev.zoral.com.ua> <4FAD0DF4.9000609@freebsd.org> <36CFD0BA-5047-42C5-9FE5-5D057CEFBAD9@bsdimp.com> In-Reply-To: <36CFD0BA-5047-42C5-9FE5-5D057CEFBAD9@bsdimp.com> X-Enigmail-Version: 1.5pre Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Sendgrid-EID: A6W2xSVPHetogaU8rnzccWwgBYtN+QvIzXyjfe/10PEfi8L8402D+A5A3Y91z2/IohEDDbMObXmEqKk7hlGMfcanNxZxrHm2a4lvebh+NxYlP+OlRllsad6bVygO1siWbnJ/UAAc0tt/4Pz+yhey/Q== Cc: Konstantin Belousov , svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, Gabor Kovesdan Subject: Re: svn commit: r235267 - in head/usr.bin/sort: . nls X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 May 2012 20:37:50 -0000 On 05/11/12 13:08, Warner Losh wrote: > On May 11, 2012, at 9:02 AM, Colin Percival wrote: >> On 05/11/12 05:48, Konstantin Belousov wrote: >>> On Fri, May 11, 2012 at 12:37:16PM +0000, Gabor Kovesdan wrote: >>>> +bool byte_sort = false; + +static wchar_t **wmonths = NULL; +static >>>> unsigned char **cmonths = NULL; >>> >>> Such initializations are useless. You only increase the size of the binary >>> on the disk as the consequence. >> >> I just tested this hypothesis, and found no change in binary size using >> either clang or gcc46. Presumably they're smart enough to ignore explicit >> (and unnecessary) initializations of statics to zero. > > How did you test this? size(1) or ls(1)? If ls, then you may be running into the page rounding of the .text and .data sections... size(1), ls(1)-before-strip(1), and ls(1)-after-strip(1). -- Colin Percival Security Officer, FreeBSD | freebsd.org | The power to serve Founder / author, Tarsnap | tarsnap.com | Online backups for the truly paranoid