From owner-cvs-all Sat Mar 24 9:55: 8 2001 Delivered-To: cvs-all@freebsd.org Received: from moby.geekhouse.net (moby.geekhouse.net [64.81.6.36]) by hub.freebsd.org (Postfix) with ESMTP id D438A37B71B; Sat, 24 Mar 2001 09:54:57 -0800 (PST) (envelope-from jhb@FreeBSD.org) Received: from laptop.baldwin.cx (john@dhcp152.geekhouse.net [192.168.1.152]) by moby.geekhouse.net (8.11.3/8.11.3) with ESMTP id f2OHtDj17986; Sat, 24 Mar 2001 09:55:13 -0800 (PST) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20010324092549.A2225@dragon.nuxi.com> Date: Sat, 24 Mar 2001 09:54:30 -0800 (PST) From: John Baldwin To: "David O'Brien" Subject: Re: cvs commit: src/usr.sbin/sysinstall label.c menus.c Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, "Jordan K. Hubbard" Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On 24-Mar-01 David O'Brien wrote: > On Fri, Mar 23, 2001 at 12:06:20AM -0800, Jordan K. Hubbard wrote: >> Modified files: >> usr.sbin/sysinstall label.c menus.c >> Log: >> Eliminate an old warning brought about by insufficient foresight when >> creating >> the Menu structure. Have I ever mentioned that sysinstall really needs to >> be rewritten? > > You broke the Alpha build: > > /usr/src/usr.sbin/sysinstall/menus.c:1323: initializer element is not > computable at load time > /usr/src/usr.sbin/sysinstall/menus.c:1323: (near initialization for > `MenuNetworking.items[9].aux') > > Reverting the "(int)" cast fixes the problem. And is bogus. Int on the alpha is 32 bits, where as a const char * is 64 bits. Either libdialog needs to be fixed so that dialog.h defines dialogMenuItem.aux as a void * rather than a long, or we need to change to having the data field point to a struct containing a pointer to a string and a pointer to a submenu and have dmenuVarCheck and dmenuSubmenu (or suitable wrappers) just use the appropriate pointer from that struct. This is probably the better solution but requires more work. :) -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message