From owner-svn-src-all@freebsd.org Thu Mar 17 04:29:51 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 35439AD277C; Thu, 17 Mar 2016 04:29:51 +0000 (UTC) (envelope-from delphij@gmail.com) Received: from mail-ig0-x22c.google.com (mail-ig0-x22c.google.com [IPv6:2607:f8b0:4001:c05::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id F2F78B8B; Thu, 17 Mar 2016 04:29:50 +0000 (UTC) (envelope-from delphij@gmail.com) Received: by mail-ig0-x22c.google.com with SMTP id kc10so2772100igb.0; Wed, 16 Mar 2016 21:29:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=gJias83QCcII5JVFAZ0UeJUTgkM/cXjzpUJ/dq37cr8=; b=jOouTyzPBkG0K7yC+dZTb3LCGK9dIuYjk3PrmLLq1C/1Dza+PuSEPa+gi+IR9rqzph T8P7TW10Bn32W9/YWP5ZzxUavASNY28mIrdwkhZ/lg6PmS3ZolP7tEOPQJicaBSjbs07 P46y2axJ/Zg5RQFWKRyJvcZdNi6MNXIHcYXj4VRfuUL/kCilLvBs1BGbElMS9sMtcM1l r+q1H+5E/8Knfo2V0lFIIRRT/NerwvFIEvBnA0ADriR9fC1DLapJhK41PM4v0f3CkYiU sCkmSWBEFIOprMw/ixJHixYIurkj2P6PzLH9FTnIGzm+d2O210QgGzCWnpzRcm+Jov1c QMyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=gJias83QCcII5JVFAZ0UeJUTgkM/cXjzpUJ/dq37cr8=; b=Hh18Kn6DV871LFf4BDcylmU91YO3HxyBwmCsmh4pi8WdMA/b2XPU1P/yFa2k4rIBVH /6Gn2i9jYBWYaHq9rtvOif1Tz91dytGbtPwoaXTaW7fURxtjxVSuWEnp6qWh/NbZWyM1 SbKyENp3No+MP9/coDXcoH6WCMqAA+m6vrmf1CzkfAoMi6VP60XHYav8NbHxmdrk5UZq n0Jtv/VIj7vTi8legq94gB9Mg59wM1jcIh8zAygKRP1doZ9KIkhyTGqYDQh20w+GB/JA pyNQoD6qiIPPtn3ddxMLDQ9LFaV2htxGQIEb9kNmdj9SeNvuUtiPJeiLwPUkr9DM2t4t Xz8g== X-Gm-Message-State: AD7BkJJXzpqcFUo2evTg5qFFOyonsD05a1GTlRgneljoNcTYAzddVPHw4EREyrRsy+7j93I4xnpieSX+Gv9DHQ== MIME-Version: 1.0 X-Received: by 10.50.160.41 with SMTP id xh9mr2871827igb.91.1458188990242; Wed, 16 Mar 2016 21:29:50 -0700 (PDT) Received: by 10.36.54.207 with HTTP; Wed, 16 Mar 2016 21:29:50 -0700 (PDT) In-Reply-To: References: <201509040014.t840ELno034811@repo.freebsd.org> Date: Wed, 16 Mar 2016 21:29:50 -0700 Message-ID: Subject: Re: svn commit: r287445 - in head: bin/setfacl lib/libc/posix1e share/man/man9 sys/cddl/compat/opensolaris/kern sys/cddl/contrib/opensolaris/uts/common/sys sys/kern sys/sys tools/regression/acltools From: Xin LI To: Alan Somers , Sean Fagan Cc: Xin LI , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Mar 2016 04:29:51 -0000 +sef who created the patch... On Wed, Mar 16, 2016 at 3:40 PM, Alan Somers wrote: > > > On Thu, Sep 3, 2015 at 6:14 PM, Xin LI wrote: >> >> Author: delphij >> Date: Fri Sep 4 00:14:20 2015 >> New Revision: 287445 >> URL: https://svnweb.freebsd.org/changeset/base/287445 >> >> Log: >> Expose an interface to determine if an ACE is inherited. >> >> Submitted by: sef >> Reviewed by: trasz >> MFC after: 2 weeks >> Differential Revision: https://reviews.freebsd.org/D3540 >> >> Modified: >> head/bin/setfacl/setfacl.1 >> head/lib/libc/posix1e/acl_add_flag_np.3 >> head/lib/libc/posix1e/acl_support_nfs4.c >> head/share/man/man9/acl.9 >> head/sys/cddl/compat/opensolaris/kern/opensolaris_acl.c >> head/sys/cddl/contrib/opensolaris/uts/common/sys/acl.h >> head/sys/kern/subr_acl_nfs4.c >> head/sys/sys/acl.h >> head/tools/regression/acltools/tools-crossfs.test >> head/tools/regression/acltools/tools-nfs4-psarc.test >> head/tools/regression/acltools/tools-nfs4-trivial.test >> head/tools/regression/acltools/tools-nfs4.test > > > ... > >> >> Modified: head/sys/sys/acl.h >> >> ============================================================================== >> --- head/sys/sys/acl.h Thu Sep 3 22:15:56 2015 (r287444) >> +++ head/sys/sys/acl.h Fri Sep 4 00:14:20 2015 (r287445) >> @@ -249,11 +249,12 @@ typedef void *acl_t; >> #define ACL_ENTRY_INHERIT_ONLY 0x0008 >> #define ACL_ENTRY_SUCCESSFUL_ACCESS 0x0010 >> #define ACL_ENTRY_FAILED_ACCESS 0x0020 >> +#define ACL_ENTRY_INHERITED 0x0080 >> >> #define ACL_FLAGS_BITS (ACL_ENTRY_FILE_INHERIT | >> \ >> ACL_ENTRY_DIRECTORY_INHERIT | ACL_ENTRY_NO_PROPAGATE_INHERIT | \ >> ACL_ENTRY_INHERIT_ONLY | ACL_ENTRY_SUCCESSFUL_ACCESS | \ >> - ACL_ENTRY_FAILED_ACCESS) >> + ACL_ENTRY_FAILED_ACCESS | ACL_ENTRY_INHERITED) >> >> /* >> * Undefined value in ae_id field. ae_id should be set to this value > > > Out of curiosity, why did you choose 0x0080 for ACL_ENTRY_INHERITED instead > of 0x0040 ? > -- Xin LI https://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die