From owner-cvs-src@FreeBSD.ORG Sat Aug 14 15:32:40 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D31C116A4CE; Sat, 14 Aug 2004 15:32:40 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CA39A43D41; Sat, 14 Aug 2004 15:32:40 +0000 (GMT) (envelope-from dwmalone@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i7EFWeIo043733; Sat, 14 Aug 2004 15:32:40 GMT (envelope-from dwmalone@repoman.freebsd.org) Received: (from dwmalone@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i7EFWeXe043732; Sat, 14 Aug 2004 15:32:40 GMT (envelope-from dwmalone) Message-Id: <200408141532.i7EFWeXe043732@repoman.freebsd.org> From: David Malone Date: Sat, 14 Aug 2004 15:32:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/contrib/pf/net if_pfsync.c pf_norm.c src/sys/modules/pf Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Aug 2004 15:32:41 -0000 dwmalone 2004-08-14 15:32:40 UTC FreeBSD src repository Modified files: sys/contrib/pf/net if_pfsync.c pf_norm.c sys/modules/pf Makefile Log: Get rid of the RANDOM_IP_ID option and make it a sysctl. NetBSD have already done this, so I have styled the patch on their work: 1) introduce a ip_newid() static inline function that checks the sysctl and then decides if it should return a sequential or random IP ID. 2) named the sysctl net.inet.ip.random_id 3) IPv6 flow IDs and fragment IDs are now always random. Flow IDs and frag IDs are significantly less common in the IPv6 world (ie. rarely generated per-packet), so there should be smaller performance concerns. The sysctl defaults to 0 (sequential IP IDs). Reviewed by: andre, silby, mlaier, ume Based on: NetBSD MFC after: 2 months Revision Changes Path 1.11 +0 -5 src/sys/contrib/pf/net/if_pfsync.c 1.10 +0 -4 src/sys/contrib/pf/net/pf_norm.c 1.4 +2 -5 src/sys/modules/pf/Makefile