Date: Tue, 31 Mar 2009 11:49:07 -0500 From: Robert Noland <rnoland@FreeBSD.org> To: Kevin Oberman <oberman@es.net> Cc: freebsd-x11@FreeBSD.org Subject: Re: Xorg 7.4 crashes on exit Message-ID: <1238518147.8491.373.camel@balrog.2hip.net> In-Reply-To: <20090331163606.855B01CC29@ptavv.es.net> References: <20090331163606.855B01CC29@ptavv.es.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-nEUE3kb/lfif5rkpyHuj
Content-Type: multipart/mixed; boundary="=-rQdyBiQv6uXpi4LzOd9a"
--=-rQdyBiQv6uXpi4LzOd9a
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
On Tue, 2009-03-31 at 09:36 -0700, Kevin Oberman wrote:
> > Date: Tue, 31 Mar 2009 16:16:57 +0100
> > From: "N.J. Mann" <njm@njm.me.uk>
> >=20
> > Hi Robert,
> >=20
> >=20
> > In message <1238445388.8491.358.camel@balrog.2hip.net>,
> > Robert Noland (rnoland@FreeBSD.org) wrote:
> > > On Mon, 2009-03-30 at 13:11 -0700, Kevin Oberman wrote:
> > > > > From: Robert Noland <rnoland@FreeBSD.org>
> > > > > Date: Mon, 30 Mar 2009 14:54:45 -0500
> > [snip]
> > > > >=20
> > > > > Is this on CURRENT or STABLE and do you know at least approximate=
ly when
> > > > > you started seeing the issue?
> > > > >=20
> > > >=20
> > > > It is on stable and I THINK it started when I updated my system to
> > > > 7.2-PRERELEASE last week. My previous Stable was on February 7 and =
it
> > > > pre-dated the Xorg-1.5.3 server update on the system.
> > > >=20
> > > > I normally update ports daily, but I did delay the Xorg update for =
a
> > > > week or two to let dust settle.
> > >=20
> > > There are a lot of changed in that window... I really hope that this
> > > doesn't fix it, but could you try reverting:
> > >=20
> > > balrog% svn diff -c r189669
> > > Index: drm_drv.c
> > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > > --- drm_drv.c (revision 189668)
> > > +++ drm_drv.c (revision 189669)
> > > @@ -131,7 +131,7 @@
> > > .d_poll =3D drm_poll,
> > > .d_mmap =3D drm_mmap,
> > > .d_name =3D "drm",
> > > - .d_flags =3D D_TRACKCLOSE | D_NEEDGIANT
> > > + .d_flags =3D D_TRACKCLOSE
> > > };
> > > =20
> > > static struct drm_msi_blacklist_entry drm_msi_blacklist[] =3D {
> >=20
> > I was not sure whether you wanted Kevin, me or both of us to try the
> > above, so I tried it anyway. :-) It has no visible affect here at all.
> > I double checked I had patched the right file and even re-compiled
> > (after doing a rm -rf /usr/obj and a make clean) and re-installed the
> > resulting kernel. No change.
> >=20
> > Are there any debug messages I can enable to help you out here?
>=20
> For me and my Radeon, the change seems to have "fixed" the problem.=20
>=20
> I have rebooted several times, including after loading the system with a
> variety of graphics oriented tasks (Flash, MPEGs, WMV, ...), I have been
> unable to trigger the problem with the NEEDGIANT. I don't have witness
> in my kernel and really would have problems with having it there on this
> system this week as I am on-call. Yuck!
Ok, could you try removing that and applying this attached change
instead:
r190565 | rnoland | 2009-03-30 13:01:42 -0500 (Mon, 30 Mar 2009) | 5
lines
We don't know what these pages are going to be used for, they should be
un-cached. This got lost somewhere with all the bus_dma fixups.
robert.
--=20
Robert Noland <rnoland@FreeBSD.org>
FreeBSD
--=-rQdyBiQv6uXpi4LzOd9a
Content-Disposition: attachment; filename="drm-190565.patch"
Content-Transfer-Encoding: base64
Content-Type: text/x-patch; name="drm-190565.patch"; charset="us-ascii"
SW5kZXg6IGRybV9wY2kuYw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIGRybV9wY2kuYwkocmV2aXNpb24gMTkw
NTY0KQ0KKysrIGRybV9wY2kuYwkocmV2aXNpb24gMTkwNTY1KQ0KQEAgLTkxLDcgKzkxLDcgQEAN
CiAJfQ0KIA0KIAlyZXQgPSBidXNfZG1hbWVtX2FsbG9jKGRtYWgtPnRhZywgJmRtYWgtPnZhZGRy
LA0KLQkgICAgQlVTX0RNQV9XQUlUT0sgfCBCVVNfRE1BX1pFUk8sICZkbWFoLT5tYXApOw0KKwkg
ICAgQlVTX0RNQV9XQUlUT0sgfCBCVVNfRE1BX1pFUk8gfCBCVVNfRE1BX05PQ0FDSEUsICZkbWFo
LT5tYXApOw0KIAlpZiAocmV0ICE9IDApIHsNCiAJCWJ1c19kbWFfdGFnX2Rlc3Ryb3koZG1haC0+
dGFnKTsNCiAJCWZyZWUoZG1haCwgRFJNX01FTV9ETUEpOw0K
--=-rQdyBiQv6uXpi4LzOd9a--
--=-nEUE3kb/lfif5rkpyHuj
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.11 (FreeBSD)
iEYEABECAAYFAknSSYMACgkQM4TrQ4qfRONTxACfdpbD4qL23O5VkZBwIosbma4o
PWsAmwSQUGaxtLv0wPXnmiWRvf9lN8H6
=KgtA
-----END PGP SIGNATURE-----
--=-nEUE3kb/lfif5rkpyHuj--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1238518147.8491.373.camel>