From owner-cvs-all Thu Jul 4 5:13:44 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6651F37B400 for ; Thu, 4 Jul 2002 05:13:42 -0700 (PDT) Received: from south.nanolink.com (south.nanolink.com [217.75.134.10]) by mx1.FreeBSD.org (Postfix) with SMTP id 4575B43E4A for ; Thu, 4 Jul 2002 05:13:40 -0700 (PDT) (envelope-from roam@ringlet.net) Received: (qmail 52679 invoked by uid 85); 4 Jul 2002 12:26:05 -0000 Received: from unknown (HELO straylight.ringlet.net) (212.116.140.125) by south.nanolink.com with SMTP; 4 Jul 2002 12:26:03 -0000 Received: (qmail 3711 invoked by uid 1000); 4 Jul 2002 12:12:10 -0000 Date: Thu, 4 Jul 2002 15:12:10 +0300 From: Peter Pentchev To: Dag-Erling Smorgrav Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libpam/modules Makefile.inc Message-ID: <20020704121209.GA382@straylight.oblivion.bg> Mail-Followup-To: Dag-Erling Smorgrav , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org References: <200207032147.g63LlbfW070234@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: User-Agent: Mutt/1.5.1i X-Virus-Scanned: by Nik's Monitoring Daemon (AMaViS perl-11d ) Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, Jul 03, 2002 at 11:51:06PM +0200, Dag-Erling Smorgrav wrote: > CVS died halfway through a larger commit when it hit this file, hence > the forced commit in src/lib/lib/libpam to get the commit message out > to the list. I had to log in on freefall and commit locally to get it > to accept the file at all. Uhm.. did you leave in some debugging aids? :) It would seem that the printf to stderr causes sudo to emit a double password prompt for some reason; with the attached patch, everything is fine. Thanks again for your efforts on PAM! G'luck, Peter --=20 Peter Pentchev roam@ringlet.net roam@FreeBSD.org PGP key: http://people.FreeBSD.org/~roam/roam.key.asc Key fingerprint FDBA FD79 C26F 3C51 C95E DF9E ED18 B68D 1619 4553 This would easier understand fewer had omitted. Index: src/lib/libpam/libpam/pam_get_pass.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /home/ncvs/src/lib/libpam/libpam/Attic/pam_get_pass.c,v retrieving revision 1.1.1.1.6.2 diff -u -r1.1.1.1.6.2 pam_get_pass.c --- src/lib/libpam/libpam/pam_get_pass.c 3 Jul 2002 21:45:44 -0000 1.1.1.1.= 6.2 +++ src/lib/libpam/libpam/pam_get_pass.c 4 Jul 2002 12:07:03 -0000 @@ -82,8 +82,6 @@ return retval; } =20 -fprintf(stderr, "[pam_get_pass]\n%s\n", prompt); - if (item =3D=3D NULL) { /* The user hasn't entered a password yet. */ if (pam_test_option(options, PAM_OPT_USE_FIRST_PASS, NULL)) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message