Date: Thu, 26 Feb 2015 14:17:07 -0800 From: Adrian Chadd <adrian@freebsd.org> To: hiren panchasara <hiren@strugglingcoder.info> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r279300 - in head/sys: kern sys Message-ID: <CAJ-VmonQB-9Wa0Bu6UGzeyt64S2v9sUJP2LuLJ58RX=Avj1ZHg@mail.gmail.com> In-Reply-To: <20150226212253.GE95752@strugglingcoder.info> References: <201502252159.t1PLx3UQ053872@svn.freebsd.org> <20150226212253.GE95752@strugglingcoder.info>
next in thread | previous in thread | raw e-mail | index | archive | help
I'm going to do this soon. Just need to get some help from doc@. I was waiting until I killed _pinned() so I wouldn't have to do it twice. Thanks (and keep poking me until i do it!) -a On 26 February 2015 at 13:22, hiren panchasara <hiren@strugglingcoder.info> wrote: > On 02/25/15 at 09:59P, Adrian Chadd wrote: >> Author: adrian >> Date: Wed Feb 25 21:59:03 2015 >> New Revision: 279300 >> URL: https://svnweb.freebsd.org/changeset/base/279300 >> >> Log: >> Remove taskqueue_start_threads_pinned(); there's noa generic cpuset version of this. >> >> Sponsored by: Norse Corp, Inc. >> >> Modified: >> head/sys/kern/subr_taskqueue.c >> head/sys/sys/taskqueue.h >> >> Modified: head/sys/kern/subr_taskqueue.c >> ============================================================================== >> --- head/sys/kern/subr_taskqueue.c Wed Feb 25 21:44:53 2015 (r279299) >> +++ head/sys/kern/subr_taskqueue.c Wed Feb 25 21:59:03 2015 (r279300) >> @@ -659,30 +659,6 @@ taskqueue_start_threads_cpuset(struct ta >> return (error); >> } >> >> -int >> -taskqueue_start_threads_pinned(struct taskqueue **tqp, int count, int pri, >> - int cpu_id, const char *name, ...) >> -{ >> - cpuset_t mask; >> - va_list ap; >> - int error; >> - >> - /* >> - * In case someone passes in NOCPU, just fall back to the >> - * default behaviour of "don't pin". >> - */ >> - if (cpu_id != NOCPU) { >> - CPU_ZERO(&mask); >> - CPU_SET(cpu_id, &mask); >> - } >> - >> - va_start(ap, name); >> - error = _taskqueue_start_threads(tqp, count, pri, >> - cpu_id == NOCPU ? NULL : &mask, name, ap); >> - va_end(ap); >> - return (error); >> -} >> - >> static inline void >> taskqueue_run_callback(struct taskqueue *tq, >> enum taskqueue_callback_type cb_type) >> >> Modified: head/sys/sys/taskqueue.h >> ============================================================================== >> --- head/sys/sys/taskqueue.h Wed Feb 25 21:44:53 2015 (r279299) >> +++ head/sys/sys/taskqueue.h Wed Feb 25 21:59:03 2015 (r279300) >> @@ -74,10 +74,6 @@ int taskqueue_start_threads(struct taskq >> const char *name, ...) __printflike(4, 5); >> int taskqueue_start_threads_cpuset(struct taskqueue **tqp, int count, >> int pri, cpuset_t *mask, const char *name, ...) __printflike(5, 6); >> -int taskqueue_start_threads_pinned(struct taskqueue **tqp, int count, >> - int pri, int cpu_id, const char *name, >> - ...) __printflike(5, 6); >> - >> int taskqueue_enqueue(struct taskqueue *queue, struct task *task); >> int taskqueue_enqueue_timeout(struct taskqueue *queue, >> struct timeout_task *timeout_task, int ticks); >> > > Can you please update the manpage if you haven't already? > > Cheers, > Hiren
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-VmonQB-9Wa0Bu6UGzeyt64S2v9sUJP2LuLJ58RX=Avj1ZHg>