From owner-svn-src-user@FreeBSD.ORG Tue Dec 22 15:45:39 2009 Return-Path: Delivered-To: svn-src-user@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1790310656A6; Tue, 22 Dec 2009 15:45:39 +0000 (UTC) (envelope-from luigi@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 071BB8FC16; Tue, 22 Dec 2009 15:45:39 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id nBMFjcsk068404; Tue, 22 Dec 2009 15:45:38 GMT (envelope-from luigi@svn.freebsd.org) Received: (from luigi@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id nBMFjcKj068402; Tue, 22 Dec 2009 15:45:38 GMT (envelope-from luigi@svn.freebsd.org) Message-Id: <200912221545.nBMFjcKj068402@svn.freebsd.org> From: Luigi Rizzo Date: Tue, 22 Dec 2009 15:45:38 +0000 (UTC) To: src-committers@freebsd.org, svn-src-user@freebsd.org X-SVN-Group: user MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r200846 - user/luigi/ipfw3-head/sys/netinet/ipfw X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Dec 2009 15:45:39 -0000 Author: luigi Date: Tue Dec 22 15:45:38 2009 New Revision: 200846 URL: http://svn.freebsd.org/changeset/base/200846 Log: add a comment on locking Modified: user/luigi/ipfw3-head/sys/netinet/ipfw/ip_fw_table.c Modified: user/luigi/ipfw3-head/sys/netinet/ipfw/ip_fw_table.c ============================================================================== --- user/luigi/ipfw3-head/sys/netinet/ipfw/ip_fw_table.c Tue Dec 22 15:41:58 2009 (r200845) +++ user/luigi/ipfw3-head/sys/netinet/ipfw/ip_fw_table.c Tue Dec 22 15:45:38 2009 (r200846) @@ -34,6 +34,9 @@ __FBSDID("$FreeBSD$"); * keys are network prefixes (addr/masklen), and values are integers. * As a degenerate case we can interpret keys as 32-bit integers * (with a /32 mask). + * + * The table is protected by the IPFW lock even for manipulation coming + * from userland, because operations are typically fast. */ #if !defined(KLD_MODULE)