From owner-cvs-src@FreeBSD.ORG Mon Oct 31 14:20:46 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 44A5B16A41F; Mon, 31 Oct 2005 14:20:46 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6711E43D48; Mon, 31 Oct 2005 14:20:40 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.3/8.13.3) with ESMTP id j9VEKYqp087900; Mon, 31 Oct 2005 17:20:35 +0300 (MSK) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.3/8.13.3/Submit) id j9VEKYej087899; Mon, 31 Oct 2005 17:20:34 +0300 (MSK) (envelope-from yar) Date: Mon, 31 Oct 2005 17:20:34 +0300 From: Yar Tikhiy To: Doug Barton Message-ID: <20051031142034.GA87491@comp.chem.msu.su> References: <200510281655.j9SGtcqC033700@repoman.freebsd.org> <4363B7ED.8060300@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4363B7ED.8060300@FreeBSD.org> User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc/rc.d devd ipmon newsyslog powerd sendmail X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Oct 2005 14:20:46 -0000 On Sat, Oct 29, 2005 at 10:57:01AM -0700, Doug Barton wrote: > Yar Tikhiy wrote: > > yar 2005-10-28 16:55:38 UTC > > > > FreeBSD src repository > > > > Modified files: > > etc/rc.d devd ipmon newsyslog powerd sendmail > > Log: > > Use ${name} in pathnames where appropriate. > > The sendmail script already was on this way, > > but it didn't reach the end of it yet. > > > > Revision Changes Path > > 1.8 +1 -1 src/etc/rc.d/devd > > 1.14 +1 -1 src/etc/rc.d/ipmon > > 1.4 +1 -1 src/etc/rc.d/newsyslog > > 1.3 +1 -1 src/etc/rc.d/powerd > > 1.16 +3 -3 src/etc/rc.d/sendmail > > > > http://www.FreeBSD.org/cgi/cvsweb.cgi/src/etc/rc.d/devd.diff?&r1=1.7&r2=1.8&f=h > > http://www.FreeBSD.org/cgi/cvsweb.cgi/src/etc/rc.d/ipmon.diff?&r1=1.13&r2=1.14&f=h > > http://www.FreeBSD.org/cgi/cvsweb.cgi/src/etc/rc.d/newsyslog.diff?&r1=1.3&r2=1.4&f=h > > http://www.FreeBSD.org/cgi/cvsweb.cgi/src/etc/rc.d/powerd.diff?&r1=1.2&r2=1.3&f=h > > http://www.FreeBSD.org/cgi/cvsweb.cgi/src/etc/rc.d/sendmail.diff?&r1=1.15&r2=1.16&f=h > > Were there reasons other than semantic correctness for this change? I am > generally hesitant to churn things like this where nothing is broken. Indeed, the change looks like a cosmetic one. However, a similar issue in rc.d/ppp-user drew our attention to a somewhat greater problem with the script -- see this thread: http://lists.freebsd.org/pipermail/freebsd-rc/2005-October/000316.html Therefore I decided that the rest of rc.d scripts should follow the style of using ${name} wherever appropriate, too. Most of them did so already, and I just touched a few remaining ones. A consistent style helps to uncover bugs and problems. -- Yar