Date: Wed, 23 Nov 2005 01:44:54 +0200 From: Ion-Mihai Tetcu <itetcu@people.tecnik93.com> To: pav@FreeBSD.org Cc: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/89300: [MAINTAINER] multimedia/bsdav: remove BROKEN Message-ID: <20051123014454.20ea3d62@it.buh.tecnik93.com> In-Reply-To: <1132700575.47320.16.camel@localhost> References: <200511222220.jAMMK1bB012364@freefall.freebsd.org> <20051123003447.7046be7d@it.buh.tecnik93.com> <1132699378.47320.12.camel@localhost> <20051123005108.14ffff2e@it.buh.tecnik93.com> <1132700575.47320.16.camel@localhost>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 23 Nov 2005 00:02:55 +0100
Pav Lucistnik <pav@FreeBSD.org> wrote:
> Ion-Mihai Tetcu p=C3=AD=C5=A1e v st 23. 11. 2005 v 00:51 +0200:
> > On Tue, 22 Nov 2005 23:42:58 +0100
> > Pav Lucistnik <pav@FreeBSD.org> wrote:
> >=20
> > > Ion-Mihai Tetcu p=C3=AD=C5=A1e v st 23. 11. 2005 v 00:34 +0200:
> > > > On Tue, 22 Nov 2005 22:20:01 GMT
> > > > Pav Lucistnik <pav@FreeBSD.org> wrote:
> > > >=20
> > > > > Synopsis: [MAINTAINER] multimedia/bsdav: remove BROKEN
> > > > >=20
> > > > > State-Changed-From-To: open->closed
> > > > > State-Changed-By: pav
> > > > > State-Changed-When: Tue Nov 22 22:19:30 GMT 2005
> > > > > State-Changed-Why:=20
> > > > > Committed with fixes. Next time, what about running
> > > > > portlint(1)?
> > > >=20
> > > > What was wrong ? ``^^'' =3D my comments
> > > >=20
> > > > root@it> /usr/ports/multimedia/bsdav.my [0:32:16] 0
> > > > # portlint -A
> > >=20
> > > You should be running either `portlint -AN' for new ports or
> > > `portlint -C' for updates ...
> >=20
> > Still, what was the problem ? I wanna learn, not make you loose
> > time, you know :)
> >=20
> > root@it> /usr/ports/multimedia/bsdav.my [0:46:11] 0
> > # portlint -C
> > WARN: Makefile [26]: possible direct use of command "install"
> > found. use ${INSTALL_foobaa} instead. ^^ false
> > WARN: /usr/ports/multimedia/bsdav.my/files/patch-lib_bsdav_tables.c
> > [8]: includes possible RCS tag "$Id$". use binary mode (-ko) on
> > commit/import.
> > WARN: /usr/ports/multimedia/bsdav.my/files/patch-lib_bsdav_video_hw.c
> > [8]: includes possible RCS tag "$Id$". use binary mode (-ko) on
> > commit/import. ^^ are this two a problem ? WARN: no CVS
> > directories. Use -N to check a new port. ^^ 'casue I've copied the
> > port in bsdav.my; in the PR is OK (bsdav) 0 fatal errors and 4
> > warnings found.
>=20
> I got different output. You're using latest and greatest portlint
> 2.8.0? I got the IGNORE capitalization message.
portlint-2.8.0_1
> Anyway, my changes:
>=20
> First, you don't raise PORTREVISION on change that don't affect
> package.
Not compilable so no package so bump; yeh, my bad; it was compilable on
any machine with X installed (and I suspect the vast majority of users
of a TV-capture port are running X). Somehow things got twisted in my
brain, I'll be more careful next time.=20
> Second, your IGNORE string does not make any sense when used. I fixed
> that.
OK, thanks.
=20
> Third, you used OPTIONS incorrectly. I fixed that. For details, see
> chapter in PH.
I see that:
-.ifdef(WITH_X11)
+.if !defined(WITHOUT_X11)
OK, if one does not what X it will put make.conf WITHOUT_X11=3D yes; so
the port actually works (OPTIONS-wise) but one should use WITHOUT_X11
and this is said in PH.
1 tab -> 2 tabs change - style, my bad.
Thanks and sorry for putting you to work on my behalf,
--=20
IOnut - Unregistered ;) FreeBSD "user"
"Intellectual Property" is nowhere near as valuable as "Intellect"
BOFH excuse #316:
Elves on strike (Why do they call EMAG Elf Magic?)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051123014454.20ea3d62>