From owner-svn-src-head@FreeBSD.ORG  Sun Dec 28 07:53:03 2008
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 82AD11065673;
	Sun, 28 Dec 2008 07:53:03 +0000 (UTC)
	(envelope-from phk@critter.freebsd.dk)
Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222])
	by mx1.freebsd.org (Postfix) with ESMTP id 3F41B8FC13;
	Sun, 28 Dec 2008 07:53:03 +0000 (UTC)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (unknown [192.168.61.3])
	by phk.freebsd.dk (Postfix) with ESMTP id 35C8E170E2;
	Sun, 28 Dec 2008 07:53:02 +0000 (UTC)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.14.3/8.14.3) with ESMTP id mBS7r1h9032524;
	Sun, 28 Dec 2008 07:53:01 GMT (envelope-from phk@critter.freebsd.dk)
To: Alfred Perlstein <alfred@freebsd.org>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Sat, 27 Dec 2008 21:35:30 PST."
	<20081228053530.GF18389@elvis.mu.org> 
Date: Sun, 28 Dec 2008 07:53:01 +0000
Message-ID: <32523.1230450781@critter.freebsd.dk>
Sender: phk@critter.freebsd.dk
Cc: Scott Long <scottl@samsco.org>,
	"src-committers@freebsd.org" <src-committers@freebsd.org>,
	"svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,
	"svn-src-head@freebsd.org" <svn-src-head@freebsd.org>,
	"mav@freebsd.org" <mav@freebsd.org>, "M. Warner Losh" <imp@bsdimp.com>
Subject: Re: svn commit: r186182 - head/sys/dev/ata 
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 28 Dec 2008 07:53:03 -0000

In message <20081228053530.GF18389@elvis.mu.org>, Alfred Perlstein writes:
>* Scott Long <scottl@samsco.org> [081226 18:34] wrote:

>> I prefer to do nothing.  It's not unsafe or erroneous to access cfg  
>> registers.  But if some kind of message does get added, I insist that  
>> it drop all pretenses and say, "you're too poor to run freebsd, come  
>> back when you can afford better hardware.". :)
>
>Well that could be the result of a driver that has a "bug" that
>makes it access cfg space when it does not need to, as what seems
>to have just been fixed.

How about adding a counter and a rate warning under INVARIANTS ?

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.