From owner-svn-src-all@FreeBSD.ORG Thu Aug 1 16:28:49 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id E4E6AB32; Thu, 1 Aug 2013 16:28:49 +0000 (UTC) (envelope-from melifaro@FreeBSD.org) Received: from mail.ipfw.ru (unknown [IPv6:2a01:4f8:120:6141::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id A4DED2DD4; Thu, 1 Aug 2013 16:28:49 +0000 (UTC) Received: from [2a02:6b8:0:401:222:4dff:fe50:cd2f] (helo=dhcp170-36-red.yandex.net) by mail.ipfw.ru with esmtpsa (TLSv1:CAMELLIA256-SHA:256) (Exim 4.76 (FreeBSD)) (envelope-from ) id 1V4vnC-000Plo-40; Thu, 01 Aug 2013 20:31:58 +0400 Message-ID: <51FA8C73.4070808@FreeBSD.org> Date: Thu, 01 Aug 2013 20:27:31 +0400 From: "Alexander V. Chernikov" User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130418 Thunderbird/17.0.5 MIME-Version: 1.0 To: Rui Paulo Subject: Re: svn commit: r253841 - head/sys/netinet6 References: <201307311624.r6VGOob5022079@svn.freebsd.org> <20130801142324.GG20104@FreeBSD.org> <97527D06-7783-4441-BA50-702DEE0B9076@FreeBSD.org> In-Reply-To: <97527D06-7783-4441-BA50-702DEE0B9076@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Gleb Smirnoff , src-committers@freebsd.org, Hiroki Sato X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Aug 2013 16:28:50 -0000 On 01.08.2013 20:18, Rui Paulo wrote: > On 1 Aug 2013, at 07:23, Gleb Smirnoff wrote: > >> On Wed, Jul 31, 2013 at 04:24:50PM +0000, Hiroki Sato wrote: >> H> Author: hrs >> H> Date: Wed Jul 31 16:24:49 2013 >> H> New Revision: 253841 >> H> URL: http://svnweb.freebsd.org/changeset/base/253841 >> H> >> H> Log: >> H> Allocate in6_ifextra (ifp->if_afdata[AF_INET6]) only for IPv6-capable >> H> interfaces. This eliminates unnecessary IPv6 processing for non-IPv6 >> H> interfaces. >> H> >> H> MFC after: 3 days >> H> >> H> Modified: >> H> head/sys/netinet6/in6.c >> H> head/sys/netinet6/in6_ifattach.c >> H> head/sys/netinet6/nd6.c >> H> >> H> Modified: head/sys/netinet6/in6.c >> H> ============================================================================== >> H> --- head/sys/netinet6/in6.c Wed Jul 31 15:55:01 2013 (r253840) >> H> +++ head/sys/netinet6/in6.c Wed Jul 31 16:24:49 2013 (r253841) >> H> @@ -2746,6 +2746,13 @@ in6_domifattach(struct ifnet *ifp) >> H> { >> H> struct in6_ifextra *ext; >> H> >> H> + /* There are not IPv6-capable interfaces. */ >> H> + switch (ifp->if_type) { >> H> + case IFT_PFLOG: >> H> + case IFT_PFSYNC: >> H> + case IFT_USB: >> H> + return (NULL); >> H> + } >> >> All three should just disappear as interfaces :) > > What? Why? Because thay aren't really interfaces. All they need is BPF. There is a cleaner approach described here: http://lists.freebsd.org/pipermail/freebsd-net/2012-December/034031.html > > -- > Rui Paulo > >