From owner-cvs-src@FreeBSD.ORG Sun Jul 4 16:26:24 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from green.homeunix.org (freefall.freebsd.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 43A8616A4CE; Sun, 4 Jul 2004 16:26:24 +0000 (GMT) Received: from green.homeunix.org (green@localhost [127.0.0.1]) by green.homeunix.org (8.12.11/8.12.11) with ESMTP id i64GQNTe001315; Sun, 4 Jul 2004 12:26:23 -0400 (EDT) (envelope-from green@green.homeunix.org) Received: (from green@localhost) by green.homeunix.org (8.12.11/8.12.11/Submit) id i64GQNQo001314; Sun, 4 Jul 2004 12:26:23 -0400 (EDT) (envelope-from green) Date: Sun, 4 Jul 2004 12:26:23 -0400 From: Brian Fundakowski Feldman To: Bosko Milekic Message-ID: <20040704162623.GB997@green.homeunix.org> References: <20040704161413.GA82599@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040704161413.GA82599@freefall.freebsd.org> User-Agent: Mutt/1.5.6i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/vm uma_core.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Jul 2004 16:26:24 -0000 On Sun, Jul 04, 2004 at 04:14:13PM +0000, Bosko Milekic wrote: > > This is unfair. I told you both in public and in private that > I didn't think this approach of segragating this behavior to mbuf > allocations was the right approach and even suggested what the right > approach should have been. You asked me to review a change that > further segragated this behavior to mbuf allocations but then > committed the change 5 minutes later without giving me an > opportunity to reply. > > What I've done is made the sysctl-introduction change myself and > committed it instead of this. > > In the future I hope that you'll learn to be more patient and less > righteous when ordering others not to commit something before > going through the SO. You pointed out that it was incorrect because any of the mbuf zones could be allocated from with locks held and you wanted to prevent that, so I made the change _I_ had done before less bogus. You just introduced a gaping security hole that is turned on by default. Back this out immediately. -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\