From nobody Fri Feb 6 17:59:30 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f720f6gpmz6RVpj for ; Fri, 06 Feb 2026 17:59:30 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f720f4NGLz4KNF for ; Fri, 06 Feb 2026 17:59:30 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770400770; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GSNYTIPBlK/NpuBRZ3Eb2Amyc/+pDi0t5BIPYwuCVrg=; b=DQm0ZS4U0ulAF4jS8UM5U6vy0UdpGv60t2rs+HABlninXxV4l6P9NzDXmytGBHa8HsKh62 6T/o6EONrdlpVH3K0i+BjsIur2VHYE/vLX/gxr/CQA6HYVcgNCtNFPflr7Bfxl7pLVwzk9 mVvoR+M4lFFXcT7zfi2H2nyibDTgEXJdK/9ZojPJlqMmP+MqKRhIJ0AfC4Ub2z8I+oRdle slS8EgQr9ezT0jrBc7pCd6jofzwPbsUI+a76c4N7QPCleqdNrphIpDcgAP8pHKWKz4O69P E5+oLxQTc3js7EptrRSYPuOghH3SplzDTvvlXqgPBrd/JwucIGm68hWo3vqM3w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770400770; a=rsa-sha256; cv=none; b=G1HDyaZ1FVocPQ5xSW3Ro+ASuZ+4upowLzpQI4grCQKE1ncaLbAXndoXSUBan+c+M/P3lZ kbsfyzBSLpo+ul9umsCpKFCDgVPmsEEx2SLcg2cZ5h4RsUXN+eaVParWjI1G6UIRDHygKd a3/M6oKrClZmNa5PTR9804tGJQfWDntfyLMxF/iAybxT0oO6P+8sGBQeJq+igh3qVR9gjy xpb3Ceq21NvXOMz8Mrn9Z7QARRTXGTVkaYtH9EX5Py6pYaYR9n7N5bWUYXovPcnJmXjMSc WpoGjnDfCiAkIIWbXPaDEXe8xYX8zL6sPA8NG4IjUw58LED/Fj/RSNjS7p78mQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770400770; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GSNYTIPBlK/NpuBRZ3Eb2Amyc/+pDi0t5BIPYwuCVrg=; b=og6Q6YxV/fc7QSdgpc9GZUsqWWAC6/HAfS07NN2OJ2lYPXcCXV1ku2jObEX+oJ5dX9McSB wPyzN4qMqPhlaps4u2U9iZAhWIIQe8nz/fdBIoXqEmnBMP/cHdTpo8XW5ZbLL5IHrc1WZT jQwA8uPlXWPmQVN1h6QDZhXVtwGoaG/70xVMCgDAYphf6UStns3sKM1uzcNAG3L52hLc4A BAJTWZLW1WwOuZr44NnV2poyHicE7HQAUh9Ei5y+hZjGRFFGyS/CPGj4NZTSTSrNrHQwin sJXKBP42HdpaWMoVuOTq7KwXKv3S6mOD61iO7QQq3XVMkY/xergeIbEu36MHRg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4f720f3vdYz9wP for ; Fri, 06 Feb 2026 17:59:30 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 26edb by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 06 Feb 2026 17:59:30 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Zhenlei Huang Subject: git: c10e6bc0f007 - main - qlnxe: Avoid reinitializing the interface when it is already initialized List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: zlei X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: c10e6bc0f0079e90cb484323ad71d437f1882422 Auto-Submitted: auto-generated Date: Fri, 06 Feb 2026 17:59:30 +0000 Message-Id: <69862c02.26edb.eca8b69@gitrepo.freebsd.org> The branch main has been updated by zlei: URL: https://cgit.FreeBSD.org/src/commit/?id=c10e6bc0f0079e90cb484323ad71d437f1882422 commit c10e6bc0f0079e90cb484323ad71d437f1882422 Author: Zhenlei Huang AuthorDate: 2026-02-06 17:52:54 +0000 Commit: Zhenlei Huang CommitDate: 2026-02-06 17:52:54 +0000 qlnxe: Avoid reinitializing the interface when it is already initialized qlnx_init_locked() unconditionally uninitialize the interface thus is actually reinitializing the interface. Well the init routine qlnx_init() is to initialize the interface by net stack when assigned with the first inet or inet6 address. The ioctl SIOCSIFADDR for the first inet6 address is handled by ether_ioctl() thus the interface is reinitialized no matter it was initialized or not. Add a driver status check for that to avoid reinitializing. Further plan is removing SIOCSIFADDR ioctl from the driver and let ether_ioctl() handle it. Reviewed by: kbowling MFC after: 5 days Differential Revision: https://reviews.freebsd.org/D54887 --- sys/dev/qlnx/qlnxe/qlnx_os.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/dev/qlnx/qlnxe/qlnx_os.c b/sys/dev/qlnx/qlnxe/qlnx_os.c index b0dac3a82582..bc0282e3c22b 100644 --- a/sys/dev/qlnx/qlnxe/qlnx_os.c +++ b/sys/dev/qlnx/qlnxe/qlnx_os.c @@ -2431,7 +2431,8 @@ qlnx_init(void *arg) QL_DPRINT2(ha, "enter\n"); QLNX_LOCK(ha); - qlnx_init_locked(ha); + if ((if_getdrvflags(ha->ifp) & IFF_DRV_RUNNING) == 0) + qlnx_init_locked(ha); QLNX_UNLOCK(ha); QL_DPRINT2(ha, "exit\n");