From owner-svn-ports-head@freebsd.org Mon Mar 4 22:20:54 2019 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DB4051525197; Mon, 4 Mar 2019 22:20:54 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7F7848B948; Mon, 4 Mar 2019 22:20:54 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 18F2313049; Mon, 4 Mar 2019 22:20:54 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-lj1-f181.google.com with SMTP id v10so5760509lji.3; Mon, 04 Mar 2019 14:20:54 -0800 (PST) X-Gm-Message-State: APjAAAW6yf10F6MpMy6wZ2tjguaJGVm5Cy3xRYOPreb4dGgrbZ7oYwFX +eQjhLTG/k4I6pfyHWWdqmNHrjyYABiuJc9m5ls= X-Google-Smtp-Source: APXvYqzVeYVgVRZQAC3dbbLT5Z0U7L8rkUhT/ccb/hJeaK577nar/HmUzHUgeyVK52tkvSKOz7j6FPxoQOJrCP+XiAA= X-Received: by 2002:a2e:6801:: with SMTP id c1mr12825973lja.81.1551738052577; Mon, 04 Mar 2019 14:20:52 -0800 (PST) MIME-Version: 1.0 References: <201903042208.x24M8p9x000612@repo.freebsd.org> In-Reply-To: <201903042208.x24M8p9x000612@repo.freebsd.org> From: Kyle Evans Date: Mon, 4 Mar 2019 16:20:13 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r494657 - head/x11/rofi-pass To: Steve Wills , alex@xanderio.de Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 7F7848B948 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.97)[-0.972,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Mar 2019 22:20:55 -0000 On Mon, Mar 4, 2019 at 4:09 PM Steve Wills wrote: > > Author: swills > Date: Mon Mar 4 22:08:50 2019 > New Revision: 494657 > URL: https://svnweb.freebsd.org/changeset/ports/494657 > > Log: > x11/rofi-pass: remove unnecessary dependencies > > PR: 236225 > Submitted by: alex@xanderio.de (maintainer) > Hi, I did a pass over this to make sure it wasn't using grep features that we don't quite support but don't treat as errors -- that turned out alright, but it turns out the sed usage is slightly wrong in one place [1] for our world. I would recommend sending a patch upstream to change this to the more portable expression `sed -Ee 's/[[:blank:]]+$//'`, though it's probably not critical to patch it locally since it just strips whitespace off the end (or doesn't, as the case is now =)). Thanks, Kyle Evans [1] https://github.com/carnager/rofi-pass/blob/master/addpass#L56