From owner-cvs-all@FreeBSD.ORG Thu Oct 27 06:34:08 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6314716A41F; Thu, 27 Oct 2005 06:34:08 +0000 (GMT) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (arm132.internetdsl.tpnet.pl [83.17.198.132]) by mx1.FreeBSD.org (Postfix) with ESMTP id BC8B343D46; Thu, 27 Oct 2005 06:34:07 +0000 (GMT) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 96C9550F95; Thu, 27 Oct 2005 08:34:05 +0200 (CEST) Received: from localhost (dle176.neoplus.adsl.tpnet.pl [83.24.34.176]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 2541A509F1; Thu, 27 Oct 2005 08:33:58 +0200 (CEST) Date: Thu, 27 Oct 2005 08:33:53 +0200 From: Pawel Jakub Dawidek To: Yar Tikhiy Message-ID: <20051027063353.GA63896@garage.freebsd.pl> References: <200510231406.j9NE6r8L008373@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="7JfCtLOvnd9MIVvH" Content-Disposition: inline In-Reply-To: <200510231406.j9NE6r8L008373@repoman.freebsd.org> X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 7.0-CURRENT i386 User-Agent: mutt-ng/devel-r535 (FreeBSD) X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: ** X-Spam-Status: No, score=2.6 required=3.0 tests=BAYES_00,RCVD_IN_NJABL_DUL, RCVD_IN_SORBS_DUL,RCVD_IN_XBL autolearn=no version=3.0.4 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc/rc.d ike named ppp-user sshd X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Oct 2005 06:34:08 -0000 --7JfCtLOvnd9MIVvH Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Oct 23, 2005 at 02:06:53PM +0000, Yar Tikhiy wrote: +> yar 2005-10-23 14:06:53 UTC +>=20 +> FreeBSD src repository +>=20 +> Modified files: +> etc/rc.d ike named ppp-user sshd=20 +> Log: +> Don't be lazy, set the "command" variable even if +> /etc/defaults/rc.conf will provide foo_program, too. +> By specifying "command" we explicitly say that we're +> going to rely on rc.subr(8) default methods, and +> rc.subr(8) will take advantage of this soon. +> =20 +> The majority of our rc.d scripts already set "command" +> if appropriate, so fix just the non-compliant handful. [...] +> name=3D"named" +> rcvar=3D`set_rcvar` +> +command=3D"/usr/sbin/${name}" [...] +> name=3D"ppp" +> rcvar=3D`set_rcvar` +> +command=3D"/usr/sbin/ppp" [...] +> name=3D"sshd" +> rcvar=3D`set_rcvar` +> +command=3D"/usr/sbin/${name}" Any reason you didn't used ${name} in ppp case? --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --7JfCtLOvnd9MIVvH Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD4DBQFDYHTRForvXbEpPzQRAiklAJiQ+ROz3lYY7hj5N4aliON6eqH0AKD4G6jF 5QzB6sUlkGYwRgkS0DZ2Fw== =zflN -----END PGP SIGNATURE----- --7JfCtLOvnd9MIVvH--