From owner-freebsd-ports Sun Jan 21 14:34:45 2001 Delivered-To: freebsd-ports@freebsd.org Received: from green.dyndns.org (localhost [127.0.0.1]) by hub.freebsd.org (Postfix) with ESMTP id 2355D37B401; Sun, 21 Jan 2001 14:34:24 -0800 (PST) Received: from localhost (gjcvz7@localhost [127.0.0.1]) by green.dyndns.org (8.11.1/8.11.1) with ESMTP id f0LMYHc03591; Sun, 21 Jan 2001 17:34:20 -0500 (EST) (envelope-from green@FreeBSD.org) Message-Id: <200101212234.f0LMYHc03591@green.dyndns.org> X-Mailer: exmh version 2.2 06/23/2000 with nmh-1.0.4 To: Josh Elsasser Cc: Joe Clarke , Yukihiro Nakai , green@FreeBSD.org, ports@FreeBSD.org Subject: Re: snes9x ports for 4.2-STABLE In-Reply-To: Message from Josh Elsasser of "Sun, 21 Jan 2001 15:24:19 EST." From: "Brian F. Feldman" Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sun, 21 Jan 2001 17:34:16 -0500 Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org Josh Elsasser wrote: > It segfaulted for me too. But if I patch the original patch-af (not the one > Yukihiro Nakai just sent) like so: > > --- /usr/ports/emulators/snes9x/files/patch-af Sat Jan 13 18:12:09 2001 > +++ /home/joshe/tmp/snes9x/files/patch-af Sun Jan 21 14:59:44 2001 > @@ -298,7 +298,7 @@ > + return (-1); > + } > + report_id = 0; > -+ reportlen = hid_report_size(rd, report_id, hid_input); > ++ reportlen = hid_report_size(rd, hid_input, &report_id); > + my_info->buf = (char *)malloc(reportlen); > + if (my_info->buf == NULL) > + err(1, "malloc"); > > Then it builds and runs fine. My gravis usb gamepad pro works great too, > aside from the fact that the two extra buttons are unused. You can change that to behave how you want. I rewrote the joystick button mapping function so it's actually not amazingly horrid and sickening anymore, too, so it should be easy to follow that as documentation ;) BTW, I changed the default gamepad configuration so that , when using a Gravis GamePad Pro USB, the buttons used are in the exact same configuration as those on the SNES gamepad itself. It may be worth adding more default joystick configurations and having an argument -joypresetmap "gravis gamepad pro", or something. I'm still working on getting these changes into Snes9X ... -- Brian Fundakowski Feldman \ FreeBSD: The Power to Serve! / green@FreeBSD.org `------------------------------' To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message