From owner-cvs-user Mon Sep 15 03:10:54 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.7/8.8.7) id DAA19094 for cvs-user-outgoing; Mon, 15 Sep 1997 03:10:54 -0700 (PDT) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id DAA19085; Mon, 15 Sep 1997 03:10:46 -0700 (PDT) Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.5/8.6.9) id TAA09841; Mon, 15 Sep 1997 19:58:19 +1000 Date: Mon, 15 Sep 1997 19:58:19 +1000 From: Bruce Evans Message-Id: <199709150958.TAA09841@godzilla.zeta.org.au> To: bde@zeta.org.au, rgrimes@gndrsh.aac.dev.com Subject: Re: cvs commit: src Makefile Cc: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-user@FreeBSD.ORG, rgrimes@FreeBSD.ORG Sender: owner-cvs-user@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk >> >> > Log: >> >> > When calling the src/include Makefile use the shorthand ``all beforeinstall'' >> >> > inplace of ``all installhdrs symlinks'' so those of us who run with >> >> > SHARED=copies get the right results. >> >> >> >> This just undoes rev.1.136 and defeats the point of the installhdrs target, >> >> which is to support `make install' forcing installation of symlinks here >> >> (for the temporary include directory for `make world'). >> >> >> >> SHARED=copies is the default. >> > >> >No, it does not do that. Take a very careful look, the forcing of >> >> Yes it does. Of course I looked carefully before commenting. You broke >> the main `includes' target. > >No, I fixed the main ``includes'' target, rev 1.136 broke it. Remeber >I wrote the original, I maintaine dfor the first 2 years, it should >NOT forceably do a ``make symlinks'' as it did. If something is >broken, it is elsewhere. That was then (more than 2 years ago). rev.1.136 has been working as intended for more than a month now. >> It only broke the undocumented internal `includes' target. > >Includes is _not_, and never was an internal target, or I would have >called it _includes when I wrote it. That doesn't follow. There are lots of poorly named internal targets. Try `make bootstrap'. It will make a mess unless invoked with a temporary DESTDIR. Here are the log messages for the introduction of the includes target: 2.x: ---------------------------- revision 1.6 date: 1994/08/13 22:47:28; author: jkh; state: Exp; lines: +214 -12 This is the first attempt to drag the top level Makefile Rod sent me into 2.0. It will surely need more work. Submitted by: jkh ---------------------------- No useful detail there. 1.x: ---------------------------- revision 1.6 date: 1993/08/23 20:51:34; author: rgrimes; state: Exp; lines: +93 -9 Added several new targets and world target to build releases with ---------------------------- Bruce