From nobody Fri Nov 24 16:16:54 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ScKr64mmMz52FZq; Fri, 24 Nov 2023 16:17:10 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ScKr473kjz3QMy; Fri, 24 Nov 2023 16:17:08 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20230601 header.b=gc1Ii0cj; spf=pass (mx1.freebsd.org: domain of rick.macklem@gmail.com designates 2607:f8b0:4864:20::434 as permitted sender) smtp.mailfrom=rick.macklem@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-6cb74a527ceso1734987b3a.2; Fri, 24 Nov 2023 08:17:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700842625; x=1701447425; darn=freebsd.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=OGpBaFdSRYIr/S+GoyJMU1sjJLpJIvuUYi/N2XkoSYw=; b=gc1Ii0cjXVQmjxx1FfVqhd8l5hT+DEbngDo4r7wKTDY34Lo8usdM1XQAAr5KL4HPte tRt3m7Tpszy4O3IOjPWclYkcPk7m+3sPbDWdwECuxiSSi2F4SmP9YsWzCVz/ROUBbaBn cleOgvrjlIrcRLgxu3ce0PEM+guosQRKKdF53xFVDfaCaCzRu8s5KGd0rJrSyvVDddwk dcYex/a2mXkMNIr4qMgNw2Io0KlD3MwdL8z/7UBQUkmCfEvl6Gp0pnUHlDg4gHjWFlsh NSWPIF2UU3ptkNAD9D+3GG/8RkgdslS2K+86XwzRlNrejaRMxNEpUK1i0ma/4pA5BEZH 9JtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700842625; x=1701447425; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OGpBaFdSRYIr/S+GoyJMU1sjJLpJIvuUYi/N2XkoSYw=; b=wOXX2yo3nv97ftcKudCw7/XBbCX/Yb9qnlDwwFS26iHV/lBsc68FIvkO/paCaQ43o8 Fn/3IWpqAjUFxWa+CrYYD1PvJn7CStGqHfVaANV2jvU8nK9XQKo/5+UJaTCRrNBbc0qy zAqXWSvk1ek956Uc+kkXiKafJ0uCiH4VjICJD2rpvILQ5uaWXcjrOzpFR9llq1G21L+e GbUTsl+wKE0PQiHIUf1eLBwgMGuEKjsnUyyCrjE309xOBP/AvFBf+Wv2ft3WGLrNlhlf 9chH0h2yhY+6GcOCtd1KrXhTnQJmSyC5OsYgrOTKgqk5+EZygXZ5134szJdSJ/NtnqPm 82Ug== X-Gm-Message-State: AOJu0YzFdvJlGuzTyzy099Z0VCnwpdQNCBRg/8cCq6A9iuLu4IJkxyfP 4D6SScGfFNgzjj3iv0t7hPnpXOlUFnMlaxaIyA== X-Google-Smtp-Source: AGHT+IHrhavaZ7MBydd5ZfEb7jTV5QDM4W9rsaBcaxRv+hbqYnPw5KOIORLikpuafqNatphtkI2Urfv3quS6cREEokI= X-Received: by 2002:a17:90b:4d0e:b0:280:62a7:3743 with SMTP id mw14-20020a17090b4d0e00b0028062a73743mr3488748pjb.30.1700842624618; Fri, 24 Nov 2023 08:17:04 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202311231525.3ANFPBo6039293@gitrepo.freebsd.org> <987d4593d50b9cbffb9b6443d3825499@Leidinger.net> In-Reply-To: From: Rick Macklem Date: Fri, 24 Nov 2023 08:16:54 -0800 Message-ID: Subject: Re: git: f5f277728ade - main - nfsd: Fix NFS access to .zfs/snapshot snapshots To: Mike Karels Cc: Konstantin Belousov , Alexander Leidinger , Rick Macklem , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Result: default: False [-3.59 / 15.00]; NEURAL_HAM_SHORT(-0.99)[-0.987]; NEURAL_HAM_LONG(-0.98)[-0.982]; NEURAL_HAM_MEDIUM(-0.62)[-0.619]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20230601]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; MIME_GOOD(-0.10)[text/plain]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::434:from]; TAGGED_FROM(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org,dev-commits-src-main@freebsd.org]; DKIM_TRACE(0.00)[gmail.com:+]; MID_RHS_MATCH_FROMTLD(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCPT_COUNT_SEVEN(0.00)[7]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_ONE(0.00)[1]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; FREEMAIL_CC(0.00)[gmail.com,leidinger.net,freebsd.org] X-Rspamd-Queue-Id: 4ScKr473kjz3QMy X-Spamd-Bar: --- On Fri, Nov 24, 2023 at 7:58=E2=80=AFAM Rick Macklem wrote: > > On Fri, Nov 24, 2023 at 5:18=E2=80=AFAM Mike Karels wro= te: > > > > CAUTION: This email originated from outside of the University of Guelph= . Do not click links or open attachments unless you recognize the sender an= d know the content is safe. If in doubt, forward suspicious emails to IThel= p@uoguelph.ca. > > > > > > On 24 Nov 2023, at 7:02, Konstantin Belousov wrote: > > > > > On Fri, Nov 24, 2023 at 08:50:22AM +0100, Alexander Leidinger wrote: > > >> Am 2023-11-23 16:25, schrieb Rick Macklem: > > >>> The branch main has been updated by rmacklem: > > >>> > > >>> URL: https://cgit.FreeBSD.org/src/commit/?id=3Df5f277728adec4c5b3e8= 40a1fb16bd16f8cc956d > > >>> > > >>> commit f5f277728adec4c5b3e840a1fb16bd16f8cc956d > > >>> Author: Rick Macklem > > >>> AuthorDate: 2023-11-23 15:23:33 +0000 > > >>> Commit: Rick Macklem > > >>> CommitDate: 2023-11-23 15:23:33 +0000 > > >>> > > >>> nfsd: Fix NFS access to .zfs/snapshot snapshots > > >>> > > >>> When a process attempts to access a snapshot under > > >>> //.zfs/snapshot, the snapshot is automounted. > > >>> However, without this patch, the automount does not > > >>> set mnt_exjail, which results in the snapshot not being > > >>> accessible over NFS. > > >>> > > >>> This patch defines a new function called vfs_exjail_clone() > > >>> which sets mnt_exjail from another mount point and > > >>> then uses that function to set mnt_exjail in the snapshot > > >>> automount. A separate patch that is currently a pull request > > >>> for OpenZFS, calls this function to fix the problem. > > >> > > >> May the same/similar fix like for ZFS be needed / useful for nullfs = mounted > > >> stuff? > > >> > > >> I have a ZFS dataset which is mounted via nullfs into a jail. This > > >> nullfs-mount is then exported via samba. In samba I have the shadow-= copy > > >> stuff enabled, but it doesn't work, as the jails can't access the sn= apshot. > > > > > > Jails cannot access snapshots because, as I understand, snapshots > > > are mounts. Nullfs does not provide an option to recursively bypass > > > into mounts. The patch you responded to does not automatically mounts > > > snapshots on clients, it only allows them to mount if wanted. > > > > It works for me, with main and this change, or 13.2 without a patch. > > I don't know the mechanics, but it doesn't use nullfs, and the snapshot > > does not show up as a separate filesystem with the mount command. > Yes. ZFS essentially does an automount of the snapshots under .zfs/snapsh= ot. > (As I understand it, there are non-default ZFS options that allow these t= o be > mounted manually instead.) > I can now see that these automounts are 'real mounts" in the > mountlist. The only reason > they are not visible is that they have MNT_IGNORE set on them. Oh and I forgot to mention that this automount is for some weird in memory file system that does just enough so you can see the snapshots. Once you "cd ", the vnodes are associated with the ZFS mount (dataset) and not this weird snapshot fs. (That is why it doesn't nee= d to be exported, but did need mnt_exjail to be set properly.) I might be able to test a nullfs over ZFS case later to-day and will post if I do so. rick > > Now, as for what happens when nullfs is on top of ZFS, I do not know. > What Kostik says about nullfs recursing into mounts suggests it will not = work. > I will look at it, but since I am headed to Florida for a few weeks, it m= ay > not happen until the end of the year. > > If someone can test this case and determine if there is no NFS client acc= ess > for snapshots under .zfs after applying the patch that is an > attachment in PR#275200 > when nullfs is over the ZFS file system, that would be appreciated. > > rick > > > > > Mike > > > > > You might try to set up something with autofs, no idea if it could be= made > > > to work usefully. > >