From nobody Wed May 27 09:03:46 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gQNvl2wTzz6fhDv for ; Wed, 27 May 2026 09:03:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gQNvl06S4z3XJJ for ; Wed, 27 May 2026 09:03:47 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779872627; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=odrQtqsIoDUvZr4Zfnq27rBrL+3v01zTEZFKl1IwSXs=; b=FtEVb+zhpH3D+494koezDSkGJsbHmi8w08/sPyStC6Kz6TkOmFYrOixv0A8fQAYxcmMgOw gOViQeJS9t2OjJ/sgJ74NoC4tx0oy+sqEPmLxBcgp48sYfsiidTy2D1BWIhsQId6Erweir xFWgu+FB61voLoal/hWa0tCRd8MLfQ28HmMyUOfgRXpKfXPRXqZvfk7c5LHAvax4eba7R2 7XDMD6nSrOUqNiXeHu2eWkuvLeFWmlecvYgpmiW73bbvUASJR7DrbLRy2M7FnsJl6fBd++ meJzwgGaEK4N3woUu/4GYHPNFoUk7ofe1ajGZ9gk2br04Jd4AM7B92XaBwilCA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1779872627; a=rsa-sha256; cv=none; b=t2D2C6afec4DTvVZ5gaOEqTp9IC7mF5zBMzBk0Hw6pgU6q2pKrIg19A8fW3ucIXq3AMUKY pVJKvN/wQ3JLLMICRSh2XUugQsAr/cLFb5Cxf/ZEk+eZhxsl5fdkbG3pMIa1JnaeDXN4Ge wxZ/QN2oj3ijMWI4SXxxMPhdiXLJ8HVQ/b+e88wb86AnEBCGKDhmTUjf0a0oa0TLLF7Yrg a96uXYlHOAMVm/aID6QXvWp7qN+2a+qs323sm3x7RrA77pu2lTabpVqPdYwCtCkgpOmtyf +7JOWJmQA+Pm6KTxGhprCZNAom1DQZKyoIMAZGZwyvWYegF7qg/aQLeH6KVwig== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779872627; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=odrQtqsIoDUvZr4Zfnq27rBrL+3v01zTEZFKl1IwSXs=; b=LEYMwPyyYCkKR4O52H5DPTjL9esxL5QaSDcyD98sVLJcZtcyra0YmLGUY/704jTZ/QwfgR n3vZciemKha7dNHZxh7JvTo+t/SnvrEsIKRkBMVWxYDVCOGTMl6jNJhBtf2otsrRRxgMD2 ZuI/C0X0xYMjjAM9Agrt0JcwbHgFEHc0RPs4yyjJ/5BIqoHCCJK++fOR/aGOL015Q7icMb AhddcDP9VLoCfEDKkZBpun0FLbPsez+tV7EoNNmtOHLzTdkaSu7XJN80A2QydpnOehbpyW MfeaW7SdOsx8sSMp46V6tpuqxuyvDV4wbhEzJktudJ3tn6frmK2hVglU/SY2qw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gQNvk6lFJzsQy for ; Wed, 27 May 2026 09:03:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 26576 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 27 May 2026 09:03:46 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dag-Erling=?utf-8?Q? Sm=C3=B8rg?=rav Subject: git: 6764267a99db - stable/14 - tftp: Add test case with over-long URL List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 6764267a99dbe8ec1fbb125cfc3b0f1d15bbc500 Auto-Submitted: auto-generated Date: Wed, 27 May 2026 09:03:46 +0000 Message-Id: <6a16b372.26576.3e28201f@gitrepo.freebsd.org> The branch stable/14 has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=6764267a99dbe8ec1fbb125cfc3b0f1d15bbc500 commit 6764267a99dbe8ec1fbb125cfc3b0f1d15bbc500 Author: Dag-Erling Smørgrav AuthorDate: 2026-05-22 17:57:27 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2026-05-27 09:03:29 +0000 tftp: Add test case with over-long URL This adds a test case that passes a very long URL on the command line, which would previously have resulted in a benign buffer overflow in urihandling(), detectable only by compiling tftp with ASAN enabled. MFC after: 1 week Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D57074 (cherry picked from commit b94689d036c5f5bdc04d080ff7dd5d0e9df9b8d4) --- usr.bin/tftp/tests/tftp_test.sh | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/usr.bin/tftp/tests/tftp_test.sh b/usr.bin/tftp/tests/tftp_test.sh index a4c9f3b898e7..12c008b2c78c 100644 --- a/usr.bin/tftp/tests/tftp_test.sh +++ b/usr.bin/tftp/tests/tftp_test.sh @@ -442,6 +442,29 @@ tftp_url_ipv6_cleanup() { stop_tftpd } +atf_test_case tftp_url_long cleanup +tftp_url_long_head() { + atf_set "descr" "Very long URL" + atf_set "require.user" "root" +} +tftp_url_long_body() { + start_tftpd + mkdir "${tftp_dir}/subdirectory" + local remote_file="${tftp_dir}/hello.txt" + echo "Hello, $$!" >"${remote_file}" + local local_file="${remote_file##*/}" + local d="subdirectory/../" + d="${d}${d}${d}${d}${d}${d}${d}${d}" + d="${d}${d}${d}${d}${d}${d}${d}${d}" + d="${d}${d}${d}${d}${d}${d}${d}${d}" + atf_check -s exit:1 -o match:"Illegal TFTP operation" \ + tftp "tftp://localhost/${d}${remote_file##*/}" + atf_check -s exit:1 test -f "${local_file}" +} +tftp_url_long_cleanup() { + stop_tftpd +} + atf_init_test_cases() { atf_add_test_case tftp_get_big atf_add_test_case tftp_get_host @@ -462,4 +485,5 @@ atf_init_test_cases() { atf_add_test_case tftp_url_host atf_add_test_case tftp_url_ipv4 atf_add_test_case tftp_url_ipv6 + atf_add_test_case tftp_url_long }