Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 2 Dec 2011 14:18:38 +0100
From:      Erik Cederstrand <erik@cederstrand.dk>
To:        Joel Dahl <joel@FreeBSD.org>, Robert Watson <rwatson@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Ken Smith <kensmith@FreeBSD.org>
Subject:   Re: svn commit: r228192 - head/usr.sbin/bsdinstall/scripts
Message-ID:  <08BC9075-C4E8-4156-BAAF-C097B118B7B4@cederstrand.dk>
In-Reply-To: <20111202094411.GJ23987@goofy01.vnodelab.local>
References:  <201112020038.pB20cmt6068628@svn.freebsd.org> <20111202094411.GJ23987@goofy01.vnodelab.local>

next in thread | previous in thread | raw e-mail | index | archive | help
Den 02/12/2011 kl. 10.44 skrev Joel Dahl:

> On 02-12-2011  0:38, Ken Smith wrote:
>> Author: kensmith
>> Date: Fri Dec  2 00:38:47 2011
>> New Revision: 228192
>> URL: http://svn.freebsd.org/changeset/base/228192
>>=20
>> Log:
>>  Add a screen that asks if the user would like to enable crash dumps,
>>  giving them a very brief description of the trade-offs.  Whether the
>>  user opts in or out add an entry to what will become /etc/rc.conf
>>  explaining what dumpdev is and how to turn on/off crash dumps.  The =
folks
>>  who handle interacting with users submitting PRs have asked for =
this.
>=20
> Hmm. Two things I'd like to bring up:
>=20
> * Not specifically aimed at this commit, but my recommendation
>  would be that we keep bsdinstall as simple as possible: installing =
FreeBSD
>  should require a minimum amount of keystrokes. I realise this is just =
one
>  more screen, but I hope we don't turn bsdinstall into a configuration
>  utility where you can disable/enable just about anything in rc.conf.
>=20
> * Mentioning future system crashes during installation feels awkward. =
Is that
>  really what we want? I understand the problem and how this helps us =
with
>  debugging, but this is like saying to users that what they are =
installing
>  is unstable and that it'll eventuelly crash and die. I know we =
discussed
>  ways of making crash dumps smarter in order to not fill up /var, =
which in
>  turn would allow us to always have it on. Maybe that is the right =
path?

Maybe do away with the dialog, and then unconditionally enable textdump =
in rc.conf, adding the magic so textdump_enable=3D"YES" sets up textdump =
with sane defaults.

Thanks,
Erik=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?08BC9075-C4E8-4156-BAAF-C097B118B7B4>