From owner-svn-src-all@FreeBSD.ORG Fri Dec 2 13:18:40 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C37C7106566C; Fri, 2 Dec 2011 13:18:40 +0000 (UTC) (envelope-from erik@cederstrand.dk) Received: from csmtp3.one.com (csmtp3.one.com [91.198.169.23]) by mx1.freebsd.org (Postfix) with ESMTP id 7A5498FC1B; Fri, 2 Dec 2011 13:18:40 +0000 (UTC) Received: from [10.0.0.82] (unknown [217.157.7.210]) by csmtp3.one.com (Postfix) with ESMTPA id B954124062EF; Fri, 2 Dec 2011 13:18:38 +0000 (UTC) Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Erik Cederstrand In-Reply-To: <20111202094411.GJ23987@goofy01.vnodelab.local> Date: Fri, 2 Dec 2011 14:18:38 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <08BC9075-C4E8-4156-BAAF-C097B118B7B4@cederstrand.dk> References: <201112020038.pB20cmt6068628@svn.freebsd.org> <20111202094411.GJ23987@goofy01.vnodelab.local> To: Joel Dahl , Robert Watson X-Mailer: Apple Mail (2.1084) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Ken Smith Subject: Re: svn commit: r228192 - head/usr.sbin/bsdinstall/scripts X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Dec 2011 13:18:40 -0000 Den 02/12/2011 kl. 10.44 skrev Joel Dahl: > On 02-12-2011 0:38, Ken Smith wrote: >> Author: kensmith >> Date: Fri Dec 2 00:38:47 2011 >> New Revision: 228192 >> URL: http://svn.freebsd.org/changeset/base/228192 >>=20 >> Log: >> Add a screen that asks if the user would like to enable crash dumps, >> giving them a very brief description of the trade-offs. Whether the >> user opts in or out add an entry to what will become /etc/rc.conf >> explaining what dumpdev is and how to turn on/off crash dumps. The = folks >> who handle interacting with users submitting PRs have asked for = this. >=20 > Hmm. Two things I'd like to bring up: >=20 > * Not specifically aimed at this commit, but my recommendation > would be that we keep bsdinstall as simple as possible: installing = FreeBSD > should require a minimum amount of keystrokes. I realise this is just = one > more screen, but I hope we don't turn bsdinstall into a configuration > utility where you can disable/enable just about anything in rc.conf. >=20 > * Mentioning future system crashes during installation feels awkward. = Is that > really what we want? I understand the problem and how this helps us = with > debugging, but this is like saying to users that what they are = installing > is unstable and that it'll eventuelly crash and die. I know we = discussed > ways of making crash dumps smarter in order to not fill up /var, = which in > turn would allow us to always have it on. Maybe that is the right = path? Maybe do away with the dialog, and then unconditionally enable textdump = in rc.conf, adding the magic so textdump_enable=3D"YES" sets up textdump = with sane defaults. Thanks, Erik=