From owner-freebsd-arch Sat Feb 16 22:42: 7 2002 Delivered-To: freebsd-arch@freebsd.org Received: from apollo.backplane.com (apollo.backplane.com [216.240.41.2]) by hub.freebsd.org (Postfix) with ESMTP id 7414C37B404; Sat, 16 Feb 2002 22:42:02 -0800 (PST) Received: (from dillon@localhost) by apollo.backplane.com (8.11.6/8.9.1) id g1H6fRb43456; Sat, 16 Feb 2002 22:41:27 -0800 (PST) (envelope-from dillon) Date: Sat, 16 Feb 2002 22:41:27 -0800 (PST) From: Matthew Dillon Message-Id: <200202170641.g1H6fRb43456@apollo.backplane.com> To: Julian Elischer Cc: Alfred Perlstein , Poul-Henning Kamp , arch@FreeBSD.ORG, jhb@FreeBSD.ORG, peter@wemm.org, jake@locore.ca Subject: Re: gettimeofday() and crhold()/crfree() (was Re: gettimeofday() and copyout(). Is copyout() MPSAFE on non-i386 archs? ) References: Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG :the whole point is moot.. :you don't need to get or drop the creds at all.. : :see the attached patch I'm about to commit a version of.. I like it in general, but I don't like INVARIANTS causing so much grief in the SMP path. If the whole point is to not drop the ucred in the syscall then we shouldn't drop it whether INVARIANTS is set or not. I would like to see the invariants sections simply removed. I like to run with INVARIANTS set, even on production systems, because I like the extra assertions it makes. In anycase, I am going to go ahead and commit the mutex pool part of my patch to cut down on the size of the ucred structure. Then I'm going to go through and see if we do any other messing around with credentials (like in the NFS code) to determine if removing Giant is still necessary. -Matt To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message