From nobody Wed May 7 21:52:01 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Zt89s2x6hz5vLb1; Wed, 07 May 2025 21:52:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Zt89s26lPz45RD; Wed, 07 May 2025 21:52:01 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1746654721; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=h4SMiKsgVhUyxyNiO7qaC75g2Q2ztVjLKQRHrTFuQA4=; b=RqwYkZ41kiz9bLhz7rnY8og+VBuU8wdvofGkL+G3Bcyro/agIGcGb3jiPK2ZDxWZ81rUfK jtd+p6X99nUV4CvCS4sk5Xc3BnWd8gka6vviDfy/adjCpPlKEV6TO071/hzLuC+JMVz869 lCnLfdUbgUabnWdxPlIuWaCrVbDl3B5bJZhrC9dDqgdTyFB9/RrNNLkQXiMddVWiJlbEQg 4LPF/F5WGXT28c1FVg909ZzXcimW5YQtvgRE4Hg/m1AIK2YMDmIztdxgaEWGFOJuEZYGUh wEGpzCXKEwWjJaiCljCmBeeSuZNpvqpmqjST+cdkn3RzrQksVfQYldigOrU/JA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1746654721; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=h4SMiKsgVhUyxyNiO7qaC75g2Q2ztVjLKQRHrTFuQA4=; b=QJ25URyOV3YDmsm1UBEVkvxLJW1fu2+8MqBTifakJfoi99XYEQizhbMqwMLnFSqP7LFB9j UkyansJoPUmhLJ/4LW4JMCBcZUZMNxFW/AEIvD6xX0CZyDb57PEBoj9U2YBWRKcCEgFMFf GOGklQF5izdBGQUWqB9ocERRoaodCjNrV87SpAlH5VYTmwpYyUP7P3DidEbm3cd44nHOhY 893iA75rMd6iA+G6gvm7DGeWEdsq45j8UQJbpmDKkN03ccVLn0O1br47TV2quOpX2Q/2Oy owJYUgXLGsrpNE+9ZrC4c5ATELJIBJmSbQiXF/yvYRuWH3xRmryLAanQE+Ss8A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1746654721; a=rsa-sha256; cv=none; b=ydJxhAwfthuQ2TcAfbK+nqsEeD3SLC2f33W8WOXYRgbpy13eYtbillfUpvauV5fyzIM509 xnfKtENz+toEl8rQKaUEl+P+/UGAZLsh9DM4G/pQo6c8LO6Xn+J6mpqGSFsdsKsI1tBWe0 EVkZnd4sBPB3pUxRHeYvXFG/uS12vbFXowrjxDkkcWJwt2qWERhov2oEkVQ7fdOWTX/Y4h 2OVz4lF+XvhBT83Y7Ko4fPQw1Q93jHBvGZRj67/gRUrKqY6nFdYuhgTgg2/oX44noEjFRi kKcysJG3D/rJS9EUT9rOY7xv1XYuLLLP+BMmLQmubSXIgEU3uLxkxdP0CHeg6w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Zt89s1fB1znTj; Wed, 07 May 2025 21:52:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 547Lq1us025065; Wed, 7 May 2025 21:52:01 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 547Lq1A3025062; Wed, 7 May 2025 21:52:01 GMT (envelope-from git) Date: Wed, 7 May 2025 21:52:01 GMT Message-Id: <202505072152.547Lq1A3025062@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Doug Moore Subject: git: 5b4b2c7c9b8a - main - vm_page: drop stale memq comments List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dougm X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 5b4b2c7c9b8a43eceaa3aa3d2f962599f602928b Auto-Submitted: auto-generated The branch main has been updated by dougm: URL: https://cgit.FreeBSD.org/src/commit/?id=5b4b2c7c9b8a43eceaa3aa3d2f962599f602928b commit 5b4b2c7c9b8a43eceaa3aa3d2f962599f602928b Author: Doug Moore AuthorDate: 2025-05-07 21:47:20 +0000 Commit: Doug Moore CommitDate: 2025-05-07 21:47:20 +0000 vm_page: drop stale memq comments The member memq was dropped from the vm_object struct because it was redundant. Pages were kept in an ordered tail queue, and also as leaves in a radix tree. Over time, the radix tree was enhanced so that it could iterate over pages as effectively as could the tail queue, and then a series of small changes replaced uses of the tail queue, one by one, until finally it was created and maintained but never used. So then it was removed. But two comments about its existence were not dropped, until now. Reviewed by: alc Fixes: c8d56817b80f ("vm_object: drop memq field") --- sys/vm/vm_page.c | 3 --- sys/vm/vm_page.h | 4 ---- 2 files changed, 7 deletions(-) diff --git a/sys/vm/vm_page.c b/sys/vm/vm_page.c index 869ba1634000..5ed1879c6a34 100644 --- a/sys/vm/vm_page.c +++ b/sys/vm/vm_page.c @@ -1545,9 +1545,6 @@ vm_page_iter_insert(vm_page_t m, vm_object_t object, vm_pindex_t pindex, * Complete page "m" insertion into the specified object after the * radix trie hooking. * - * The page "mpred" must precede the offset "m->pindex" within the - * specified object. - * * The object must be locked. */ static void diff --git a/sys/vm/vm_page.h b/sys/vm/vm_page.h index 979d9bd12b9f..3d7257644ef6 100644 --- a/sys/vm/vm_page.h +++ b/sys/vm/vm_page.h @@ -78,10 +78,6 @@ * A radix tree used to quickly * perform object/offset lookups * - * A list of all pages for a given object, - * so that they can be quickly deactiviated at - * time of deallocation. - * * An ordered list of pages due for pageout. * * In addition, the structure contains the object