From owner-cvs-ports@FreeBSD.ORG Sat May 20 13:16:19 2006 Return-Path: X-Original-To: cvs-ports@FreeBSD.org Delivered-To: cvs-ports@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9532116A422; Sat, 20 May 2006 13:16:19 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from mail.allbsd.org (vlsi00.si.noda.tus.ac.jp [133.31.130.32]) by mx1.FreeBSD.org (Postfix) with ESMTP id DFE1F43D49; Sat, 20 May 2006 13:16:18 +0000 (GMT) (envelope-from hrs@FreeBSD.org) Received: from delta.allbsd.org (p6168-ipbf302funabasi.chiba.ocn.ne.jp [124.87.184.168]) (authenticated bits=128) by mail.allbsd.org (8.13.1/8.13.4) with ESMTP id k4KDG6an065445; Sat, 20 May 2006 22:16:17 +0900 (JST) (envelope-from hrs@FreeBSD.org) Received: from localhost (alph.allbsd.org [192.168.0.10]) by delta.allbsd.org (8.13.4/8.13.4) with ESMTP id k4KDFP7b098583; Sat, 20 May 2006 22:15:25 +0900 (JST) (envelope-from hrs@FreeBSD.org) Date: Sat, 20 May 2006 22:15:21 +0900 (JST) Message-Id: <20060520.221521.122609088.hrs@allbsd.org> To: jylefort@FreeBSD.org From: Hiroki Sato In-Reply-To: <20060519090956.4f19dd41.jylefort@FreeBSD.org> References: <20060519075844.e1ac8d3b.jylefort@FreeBSD.org> <20060519.154122.123975929.hrs@allbsd.org> <20060519090956.4f19dd41.jylefort@FreeBSD.org> X-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-Mailer: Mew version 4.2.52 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="--Security_Multipart(Sat_May_20_22_15_21_2006_053)--" Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV version 0.88.2, clamav-milter version 0.88.2 on gatekeeper.allbsd.org X-Virus-Status: Clean Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/print/acroread7 Makefile pkg-deinstall pkg-plist.7.0.1 pkg-plist.7.0.5 ports/print/acroread7/files pkg-install.in X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 May 2006 13:16:19 -0000 ----Security_Multipart(Sat_May_20_22_15_21_2006_053)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Jean-Yves Lefort wrote in <20060519090956.4f19dd41.jylefort@FreeBSD.org>: jy> With that interpretation the port is also illegal since it's not only jy> a "new installer", but also "modifies the Software" (through brandelf, jy> for instance): jy> jy> "You may not otherwise alter or modify the Software or create a new jy> installer for the Software." I think neither the port is a new installer nor it modifies the Software, and I think pkg-install script in your patch modifies the installed file. This is my opinion as the port maintainer. jy> Can I fix pkg-deinstall by checking if $PKG_PREFIX/Adobe/Acrobat7.0 is jy> empty after deinstallation? Why do you force me on your idea? I do not like using pkg-install/pkg-deinstall to install the desktop entry in the master port, and I think it should be done by using symlink or so in another port (print/acroreadwrapper or new one), or something like acroreadwrapper's --install-plugin option. We also have to consider mixing of version 7.0.5 and 7.0.1. I can understand installing the desktop entry and the icon file is a good thing (IIRC, netchild@, mezz@, and I discussed this topic before), but at least I have not approved your patch and do not accept the installation/deinstallation scripts you committed. -- | Hiroki SATO ----Security_Multipart(Sat_May_20_22_15_21_2006_053)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQBEbxZpTyzT2CeTzy0RAsjcAKCnEPmp14eVfEo6kINTKrmRnxLXyQCgmLNQ 9FHrQnIq7YM7HEuGfEfdzhQ= =5fvP -----END PGP SIGNATURE----- ----Security_Multipart(Sat_May_20_22_15_21_2006_053)----