From owner-freebsd-hackers@freebsd.org Tue Feb 2 13:11:52 2016 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 39776A97554 for ; Tue, 2 Feb 2016 13:11:52 +0000 (UTC) (envelope-from kib@freebsd.org) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 13CA71ECF; Tue, 2 Feb 2016 13:11:50 +0000 (UTC) (envelope-from kib@freebsd.org) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id u12DBkqY083706 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Tue, 2 Feb 2016 15:11:46 +0200 (EET) (envelope-from kib@freebsd.org) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua u12DBkqY083706 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id u12DBj3Z083705; Tue, 2 Feb 2016 15:11:45 +0200 (EET) (envelope-from kib@freebsd.org) X-Authentication-Warning: tom.home: kostik set sender to kib@freebsd.org using -f Date: Tue, 2 Feb 2016 15:11:45 +0200 From: Konstantin Belousov To: Mateusz Guzik Cc: freebsd-hackers@freebsd.org, Mateusz Guzik Subject: Re: [PATCH 1/2] fork: pass arguments to fork1 in a dedicated structure Message-ID: <20160202131145.GT91220@kib.kiev.ua> References: <20160201103632.GL91220@kib.kiev.ua> <1454386069-29657-1-git-send-email-mjguzik@gmail.com> <1454386069-29657-2-git-send-email-mjguzik@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ZwgA9U+XZDXt4+m+" Content-Disposition: inline In-Reply-To: <1454386069-29657-2-git-send-email-mjguzik@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Feb 2016 13:11:52 -0000 --ZwgA9U+XZDXt4+m+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 02, 2016 at 05:07:48AM +0100, Mateusz Guzik wrote: > From: Mateusz Guzik >=20 > --- > sys/compat/cloudabi/cloudabi_proc.c | 7 +++++- > sys/compat/linux/linux_fork.c | 17 ++++++++++---- > sys/kern/init_main.c | 6 +++-- > sys/kern/kern_fork.c | 46 +++++++++++++++++++++++++------= ------ > sys/kern/kern_kthread.c | 7 ++++-- > sys/sys/proc.h | 12 ++++++++-- > 6 files changed, 68 insertions(+), 27 deletions(-) >=20 > diff --git a/sys/compat/cloudabi/cloudabi_proc.c b/sys/compat/cloudabi/cl= oudabi_proc.c > index d917337..010efca 100644 > --- a/sys/compat/cloudabi/cloudabi_proc.c > +++ b/sys/compat/cloudabi/cloudabi_proc.c > @@ -75,12 +75,17 @@ int > cloudabi_sys_proc_fork(struct thread *td, > struct cloudabi_sys_proc_fork_args *uap) > { > + struct fork_req fr =3D {}; > struct filecaps fcaps =3D {}; > struct proc *p2; > int error, fd; > =20 > cap_rights_init(&fcaps.fc_rights, CAP_FSTAT, CAP_EVENT); > - error =3D fork1(td, RFFDG | RFPROC | RFPROCDESC, 0, &p2, &fd, 0, &fcaps= ); > + fr.fr_flags =3D RFFDG | RFPROC | RFPROCDESC; > + fr.fr_procp =3D &p2; > + fr.fr_pd_fd =3D &fd; > + fr.fr_pd_fcaps =3D &fcaps; > + error =3D fork1(td, &fr); > if (error !=3D 0) > return (error); The patch is fine. Would be great to not use initializer in declaration, i.e. use bzero() instead of c99 designated initializers. --ZwgA9U+XZDXt4+m+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWsKsRAAoJEJDCuSvBvK1BAuwP+wfZssh5Krj5Oxqp4RbyVRqU RxZ44ZwWprSHsU0vnnpMwTWp0R/YbRHq+6Cb3pieY2UZEtqUv76/Iu4v2gi3Lfyt VEbn02wNDHIbaV5rzwkB1xGj2mwwcgKxIjz42OLQ2F4iYkie/i9oUbF4m9tFhKJ2 rWQqXul4+qFaPVGIzdK8amr9J5DvoSzOG3dCXH7X+VkoOf+QEs5YCrxim34gsX3O xGzX3zf+l/N5i1QTH/awWX2q5Ah1FyOjjgGu0MEestvRNiNi1KK0NDJ7OD5UNcvW bHRqMSkiP2tUdkjl2hg6etHRy1MfipJ6TAOcZjaeKhf4ffz50bT0Am+b0avgRBTg 3UNx0D41NYVal3zY8/HGXbYsUHyC3IOIEgnxILXNH6K7w4n/5FCC2K7MIAreYZ/A MV9tRqWPn2i+M4PZ7s1Ugq1PlSq1jqigofTGOFnDQ0l51EaVxyDFA5xqMwDRQFx5 169RXBS67j0JucGIDQ1kVTkQOoMG3pZmciZm1VND4KQKfXk1DWWFVugSe3TNORmH 0bERq/w9rVlUug17XbbRK0cidftu64DbhoVwbZ4/GHbZonNBMqlY6iW1H1bSBDtY 5SwKBY+jhHqpvWO6kMWff8YcTt/sWvu40EM1+O3xQkLTZfukJbQbzKF25v8sC+MJ 9qfJuED9qB9E8PBBaXea =V/nc -----END PGP SIGNATURE----- --ZwgA9U+XZDXt4+m+--