From owner-cvs-src@FreeBSD.ORG Fri Aug 29 09:40:02 2008 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 16B231065676; Fri, 29 Aug 2008 09:40:02 +0000 (UTC) (envelope-from rrs@lakerest.net) Received: from lakerest.net (unknown [IPv6:2001:240:585:2:203:6dff:fe1a:4ddc]) by mx1.freebsd.org (Postfix) with ESMTP id 9482E8FC08; Fri, 29 Aug 2008 09:40:01 +0000 (UTC) (envelope-from rrs@lakerest.net) Received: from [10.1.1.54] ([10.1.1.54]) (authenticated bits=0) by lakerest.net (8.14.1/8.14.1) with ESMTP id m7T9e0ku036462 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Fri, 29 Aug 2008 05:40:00 -0400 (EDT) (envelope-from rrs@lakerest.net) DKIM-Signature: a=rsa-sha1; c=simple/simple; d=lakerest.net; s=mail; t=1220002800; h=Cc:Message-Id:From:To:In-Reply-To:Content-Type: Content-Transfer-Encoding:Mime-Version:Subject:Date:References: X-Mailer; b=NUE3L5RV6u4yW5Fe+qTuUeYkubgg5qJOZQCXC6jG3mJxWnPr26MuRyw Rf38yCIx5J8q5J8KQUTNacd0FYRRL7A== Message-Id: <77C320B0-5288-497A-B893-7F2D20F7B8A2@lakerest.net> From: Randall Stewart To: Giorgos Keramidas In-Reply-To: <87tzd4n6z8.fsf@kobe.laptop> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v926) Date: Fri, 29 Aug 2008 05:39:59 -0400 References: <200808282031.m7SKVUdD076580@repoman.freebsd.org> <87tzd4n6z8.fsf@kobe.laptop> X-Mailer: Apple Mail (2.926) Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/netinet sctp_timer.c sctp_timer.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Aug 2008 09:40:02 -0000 MY bad for not catching it earlier.. I forgot to build LINT (which I usually do) especially when I am fixing something for a outside user (they were having panics and I realized all panics that are recoverable SHOULD be under INVARANTS, panic I think was caused by another change I put in strict_sacks really needs to be on by default and only turned off at interops...) R On Aug 28, 2008, at 5:51 PM, Giorgos Keramidas wrote: > On Thu, 28 Aug 2008 20:31:24 +0000 (UTC), Randall Stewart > wrote: >> rrs 2008-08-28 20:31:24 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/netinet sctp_timer.c sctp_timer.h >> Log: >> SVN rev 182405 on 2008-08-28 20:31:24Z by rrs >> >> ok, non static the function and put in the .h so >> when we do INVARANT compile the compiler will not >> dis the function that is not used. Hmm maybe I should have >> made it ifndef INVARIANTs.. > > gcc should be smart enough to throw away the non-static function > if SCTP is built into the kernel (and not as a module) *and* > there are no external references from other parts of the source. > So this should work fine. > > The ifndef INVARIANTS version is probably something like the > second patch I sent earlier, also at > http://people.freebsd.org/~keramida/diff/sctp-timer-20080828-02.patch > > but I didn't really 'like' having a static function inside a > large #ifndef INVARIANTS block... > > Thanks for fixing this so fast :-) > ------------------------------ Randall Stewart 803-317-4952 (cell) 803-345-0391(direct)