From owner-svn-src-all@FreeBSD.ORG Thu Jan 23 04:05:11 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id EBF25E33; Thu, 23 Jan 2014 04:05:10 +0000 (UTC) Received: from mail-qc0-x22b.google.com (mail-qc0-x22b.google.com [IPv6:2607:f8b0:400d:c01::22b]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 616F11839; Thu, 23 Jan 2014 04:05:10 +0000 (UTC) Received: by mail-qc0-f171.google.com with SMTP id n7so1840167qcx.30 for ; Wed, 22 Jan 2014 20:05:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=S7S7lbM54dbd5yISY0ro2ZhwdQN2dbVHwTW01Zes2Hc=; b=LY0drWDz7kCes+oYAB9z1eL1/7wMn2tBQm2D7pU1dRqMHg6sU+0Idq0pajV2nt6NDk dxc8NTNHBDlm5ssG34RmXFgq3D2AyAzm1JcPkbCRgdiQ/McaHRo43acP42/l6v2NxiKN Qerp5v97NO4f0Imkr4QEXFHVMAaQbV9rCLfqgYRoP25qLIleFCGS45VryW1lIJPXoiIM NtRemDm3BigKkg9b76wWTkZYlINukhu0kkm1+wOLhkUQLL9KwSrBmXxrOwvrOo+GlMbv ahSw/3/1ZdL9aAzeFDkbKD8wWqLOGRnTRp3g0sTennyfeF3C/EqNKy4CftQsx8Eo2QOC 2COQ== MIME-Version: 1.0 X-Received: by 10.140.42.180 with SMTP id c49mr7939630qga.24.1390449909564; Wed, 22 Jan 2014 20:05:09 -0800 (PST) Received: by 10.224.52.8 with HTTP; Wed, 22 Jan 2014 20:05:09 -0800 (PST) Received: by 10.224.52.8 with HTTP; Wed, 22 Jan 2014 20:05:09 -0800 (PST) In-Reply-To: <1536225.gsjt6oXMt2@pippin.baldwin.cx> References: <201401200159.s0K1xa5X012123@svn.freebsd.org> <1536225.gsjt6oXMt2@pippin.baldwin.cx> Date: Wed, 22 Jan 2014 20:05:09 -0800 Message-ID: Subject: Re: svn commit: r260898 - head/sys/kern From: Adrian Chadd To: John Baldwin Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.17 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Rui Paulo , Neel Natu X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jan 2014 04:05:11 -0000 .. Make it be an offset into the table rather than a pointer, then we can do dirty rcu style hacks to just replace and grow the table as we need more memory. Don't we have a standard way to pull memory from the top of the physmem area early on for allocations like this? Adrian On Jan 20, 2014 3:50 PM, "John Baldwin" wrote: > On Sunday 19 January 2014 18:18:03 Rui Paulo wrote: > > On 19 Jan 2014, at 17:59, Neel Natu wrote: > > > Author: neel > > > Date: Mon Jan 20 01:59:35 2014 > > > New Revision: 260898 > > > URL: http://svnweb.freebsd.org/changeset/base/260898 > > > > > > Log: > > > Bump up WITNESS_COUNT from 1024 to 1536 so there are sufficient > entries > > > for > > > WITNESS to actually work. > > > > This value should be automatically tuned... > > How do you propose to do so? This is the count of locks initialized before > witness' own SYSINIT is executed and the array it sizes is allocated > statically at compile time. This used to not be a static array, but an > intrusive list embedded in locks themselves, but we decided to shave a > pointer off of each lock that was only used for that and to use a > statically > sized table instead. > > -- > John Baldwin >