From owner-cvs-all@FreeBSD.ORG  Tue Aug 17 12:42:37 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id A396E16A4CE; Tue, 17 Aug 2004 12:42:37 +0000 (GMT)
Received: from mail.broadpark.no (mail.broadpark.no [217.13.4.2])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 34F6643D3F; Tue, 17 Aug 2004 12:42:37 +0000 (GMT)
	(envelope-from des@des.no)
Received: from dwp.des.no (37.80-203-228.nextgentel.com [80.203.228.37])
	by mail.broadpark.no (Postfix) with ESMTP
	id C8C7E3E24; Tue, 17 Aug 2004 14:43:10 +0200 (MEST)
Received: by dwp.des.no (Postfix, from userid 2602)
	id 2AC38B873; Tue, 17 Aug 2004 14:42:35 +0200 (CEST)
To: Alfred Perlstein <alfred@freebsd.org>
References: <200408152158.i7FLw2mW016740@repoman.freebsd.org>
	<20040816073314.GA57908@elvis.mu.org> <xzp657jmlqn.fsf@dwp.des.no>
	<20040816232714.GE57908@elvis.mu.org>
From: des@des.no (=?iso-8859-1?q?Dag-Erling_Sm=F8rgrav?=)
Date: Tue, 17 Aug 2004 14:42:34 +0200
In-Reply-To: <20040816232714.GE57908@elvis.mu.org> (Alfred Perlstein's
 message of "Mon, 16 Aug 2004 16:27:14 -0700")
Message-ID: <xzp657iszph.fsf@dwp.des.no>
User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/fs/pseudofs pseudofs_vncache.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Aug 2004 12:42:37 -0000

Alfred Perlstein <alfred@freebsd.org> writes:
> Maybe I'm missing some external references that can reactivate them?

If someone tries to access the file while it is being removed,
pfs_vncache_alloc() will create a new vnode since the old one is no
longer in the cache, and possibly overwrite the vnode pointer in the
pfs_node before the old vnode is released, leading to a leaked vnode.

> If so those could be prevented by flagging the node.

You're right, I didn't think of that.

DES
--=20
Dag-Erling Sm=F8rgrav - des@des.no