From nobody Wed Jun 24 00:10:07 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4glMlL2fn5z6h8yC for ; Wed, 24 Jun 2026 00:10:22 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4glMlK67XNz3k5q for ; Wed, 24 Jun 2026 00:10:21 +0000 (UTC) (envelope-from asomers@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-c07680fdd12so51366966b.3 for ; Tue, 23 Jun 2026 17:10:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1782259820; cv=none; d=google.com; s=arc-20240605; b=IucFlMYsUqBFU4k0t1QNBYFqJ3OYKRRzIxvu1RzPkhu6h/YCZ6D/OFJS9cElfRPZeT g0y+b26pCbrlc1ttmKDosSmzqqLaz/Y59D1My0diGMKOtsNkk4edZnkCimKEiwH8DrIM L9yIW8ZIK1gNq7OxSRO8Flz0rPUdCnwxIklTwE4mY5wR8ZVXHfLgqOi4kMuxO03v2Q+r Nci2Io9bTauWxCYt/Npr5ex/1u0yUcPCJT+7ez6MXrSC0XHYsQct3GOZdHIJHuA3OFS2 Wp6HJqu5qnOyi39ninkZKj5kF0apil+tDOWdzGxt2iDfVnKXU7BHoeZdcxvq+CLx5irN BvOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version; bh=eeMKH2FQazsDvJANz87gRDQUDUjXhV5hhlTBUFXqqQE=; fh=JzNas8IvsQ9Ux/lIUyocO0k9x3eUAbFkaW/PMr5PCQE=; b=WKK3pk2BMFPqxQfaNOCmmhFYPFQSZsSdGefkjlSjwfflVb4njr0axqJCkq4yqK5aI2 E/bzczf3kIUkGhsplBuva5jOGRxAWm1rCPSu8QJs0gm6bN6iSirIpoj8T3sDlwfgOHhE YEWlAL9J1WYQpaFxESz5CItCV7d9VwIWisNjqvrMyXsW0In/P0fmm+oX6BvDdS0sZcmQ ALS2duF6lLvm424XhnN8GZRw/t9FIrJMUX2uGVr+gKt7A6UAOLscWIhexNxAIXYoZ9g1 p1CkiYeqCF+hbtGRd6sfW/D6vQWrtRI9xSUCTQPJ1BGF+T0uppmAampK1/Pv6ps1TaQl CxTw==; darn=freebsd.org ARC-Authentication-Results: i=1; mx.google.com; arc=none X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782259820; x=1782864620; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=eeMKH2FQazsDvJANz87gRDQUDUjXhV5hhlTBUFXqqQE=; b=TojhVyi2rdBMMSOkksKePqG8Ss5tf/BYUxJa1C1Et/JbStUSbeldNPkhXdBZjqtA18 pQQzY4Ixe+j0Z3Zs8XRDPtydlMqs+DuCcuhs/Hq5ijEOf1WH2wbU2Z1+Y19dSXjD3PDO rWSm5dIn0lq39SpKrjw4uBtBQEcmn0Kaj3IbByD+c9m5RVMkf9J2K+mrWxg3R0jTktRI CXZh+kXI3YXsymRpmZ+TxJ46LO6Ug0Rwum7RDC5QFF5+wJ5EfyAUbN2OKrEx5trjsede 0KDhvpp6NEpzNRElZnVXSwmx3Rn2UK7JhNH/I80fDc0lp32qssfDLIj9OdzPpvkD3SGs XNVA== X-Forwarded-Encrypted: i=1; AFNElJ/lU3uymghhhszrEP6Yoq0GDOOnMKCAGsXJ6xyEsvi8TpCaFjsJjijrEEzqsa+P/vzRA662zxizAN3yhenJFzSZSUrL@freebsd.org X-Gm-Message-State: AOJu0YyprE3t+umUYQCniYL0KKft6DHrjnMWCdgABPDkcPxUZHuc5rIE vaFGIoTvbvwvXlA4uUlL4YR5Dkvl8gNPIUQHWWvTFWEmCHyb/3CxH5sQ9ENGoC8ORvx5oc3DAr1 /VHtHAlSeApzOyc0Rry3Kkuw2anl6AD9e9Q== X-Gm-Gg: AfdE7cmB0ja0tfuVJp12ssgROF5j1c2whdHCJnSJO3fN4EBOcrkT6bt15qxWaHCG1Yf JLBKTUSiksfcs8Vw2KrJFAs6G0oNYhLuphtTNKDTOzb/nqAPCpKl2siSiHFqs7XXcztqbhZyB0I fIYwLw3BduUM4p+3rFgM/zBMTLBZgW24mnpvFtwa96exbFKat8t8fzUGDOPWlgbfxOp9tbIMlIs LQGRcRIO+LJqCsi1+H2YOyY3Zhtj/w8AtfSbXe5Zng0gV0uV1fjAWaBrUVF2gLkc05Tpp2mFjD7 jYi/CWMek1xVlAZLfe1ujLwHaZlDEL3KtvxwDvMRSQeyCBz8OJYDfK5LS237HHkrcHTM X-Received: by 2002:a17:906:ee8a:b0:bf0:550:d9f with SMTP id a640c23a62f3a-c107eec8930mr301980266b.31.1782259820108; Tue, 23 Jun 2026 17:10:20 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 References: <6a3a9e2c.1d985.79db71af@gitrepo.freebsd.org> <864iispzxf.fsf@ltc.des.dev> In-Reply-To: <864iispzxf.fsf@ltc.des.dev> From: Alan Somers Date: Tue, 23 Jun 2026 18:10:07 -0600 X-Gm-Features: AVVi8CfLbmwYokC0Zii3AQnamabtRrKxq-It0TxVfBzta5tzs7HQfJQjJ7HhtNg Message-ID: Subject: Re: git: e03ed9daeb49 - main - fts: refactor to use fd-relative operations internally To: =?UTF-8?Q?Dag=2DErling_Sm=C3=B8rgrav?= Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, Jitendra Bhati Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Queue-Id: 4glMlK67XNz3k5q X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated On Tue, Jun 23, 2026 at 6:03=E2=80=AFPM Dag-Erling Sm=C3=B8rgrav wrote: > > Alan Somers writes: > > commit e03ed9daeb49fffa1d16b8d00240c65e92650d01 > > Author: Jitendra Bhati > > AuthorDate: 2026-06-12 17:07:55 +0000 > > Commit: Alan Somers > > CommitDate: 2026-06-23 14:53:56 +0000 > > > > fts: refactor to use fd-relative operations internally > > > > Replace all _open() calls with _openat() in __fts_open(), fts_read(= ), > > and fts_children(). > > > > Add fts_dirfd to FTSENT. Callers can use > > openat(ent->fts_dirfd, ent->fts_name, ...) to access files > > safely without relying on fts_accpath, which enables: > > > > 1. Capsicum capability mode where path-based operations fail > > 2. Security-sensitive programs that avoid TOCTOU races > > > > Replace statfs(ent->fts_path) with _fstatfs(ent->fts_dirfd) in > > fts_ufslinks() when fts_dirfd is valid, falling back to statfs() fo= r > > root-level entries where fts_dirfd is -1 > > > > This is a preparatory change for fts_openat() which will allow > > callers to provide a pre-opened directory fd, enabling fts(3) > > traversal inside Capsicum capability mode. > > > > Sponsored by: Google LLC (GSoC 2026) > > Reviewed by: asomers, jillest > > MFC after: 2 weeks > > Pull Request: https://github.com/freebsd/freebsd-src/pull/2278 > > This needs to be reverted. It changes struct _ftsent which is part of > the libc ABI. You will have to fork FTS (again) and have one version > with fts_dirfd and fts_openat() and one without. I don't think there's any guarantee that the size of _ftsent is fixed. Since the API only passes FTSENT around by pointer, we are free to add fields. Or am I missing something?