From owner-cvs-src@FreeBSD.ORG  Mon Mar  1 06:01:45 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 676F816A4CE; Mon,  1 Mar 2004 06:01:45 -0800 (PST)
Received: from fledge.watson.org (fledge.watson.org [204.156.12.50])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id CFE0643D1D; Mon,  1 Mar 2004 06:01:44 -0800 (PST)
	(envelope-from robert@fledge.watson.org)
Received: from fledge.watson.org (localhost [127.0.0.1])
	by fledge.watson.org (8.12.10/8.12.10) with ESMTP id i21E0cDL080514;
	Mon, 1 Mar 2004 09:00:38 -0500 (EST)
	(envelope-from robert@fledge.watson.org)
Received: from localhost (robert@localhost)i21E0cPa080511;
	Mon, 1 Mar 2004 09:00:38 -0500 (EST)
	(envelope-from robert@fledge.watson.org)
Date: Mon, 1 Mar 2004 09:00:38 -0500 (EST)
From: Robert Watson <rwatson@FreeBSD.org>
X-Sender: robert@fledge.watson.org
To: "Andrey A. Chernov" <ache@FreeBSD.org>
In-Reply-To: <200403011143.i21Bhoap028383@repoman.freebsd.org>
Message-ID: <Pine.NEB.3.96L.1040301085614.62987F-100000@fledge.watson.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/lib/libc/locale setlocale.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Mar 2004 14:01:45 -0000


On Mon, 1 Mar 2004, Andrey A. Chernov wrote:

> ache        2004/03/01 03:43:50 PST
> 
>   FreeBSD src repository
> 
>   Modified files:        (Branch: RELENG_5_2)
>     lib/libc/locale      setlocale.c 
>   Log:
>   MFC important bugfixes from v1.49-1.50
>   
>   Revision  Changes    Path
>   1.48.2.1  +39 -26    src/lib/libc/locale/setlocale.c

I don't see an "Approved by:" here, nor any sign of this change being run
by security-officer or the release engineering team.  The release
engineering page clearly identifies this branch as frozen, requiring
release engineering approval: 

  http://www.FreeBSD.org/releng/

Could you tell me who approved this commit?

The release engineering branches are under very careful control because
they are used to generate binary updates, etc, especially immediately
following a release, and unapproved commits are not acceptable, especially
given clear documentation of the purpose of the branch, as well as the
process for committing to it.  This isn't just a matter of "is the commit
content sufficient to merit inclusion", but also an issue as to the point
in the release engineering process, adequate evaluation and testing, and
its impact on the release notes, errata, et al.

Robert N M Watson             FreeBSD Core Team, TrustedBSD Projects
robert@fledge.watson.org      Senior Research Scientist, McAfee Research