From owner-cvs-all Wed Feb 26 10:46:52 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AE13C37B401; Wed, 26 Feb 2003 10:46:50 -0800 (PST) Received: from ebb.errno.com (ebb.errno.com [66.127.85.87]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0735943FA3; Wed, 26 Feb 2003 10:46:50 -0800 (PST) (envelope-from sam@errno.com) Received: from melange (melange.errno.com [66.127.85.82]) (authenticated bits=0) by ebb.errno.com (8.12.5/8.12.1) with ESMTP id h1QIkknN091471 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO); Wed, 26 Feb 2003 10:46:47 -0800 (PST)?g (envelope-from sam@errno.com)œ X-Authentication-Warning: ebb.errno.com: Host melange.errno.com [66.127.85.82] claimed to be melange Message-ID: <28e301c2ddc7$6a92ef40$52557f42@errno.com> From: "Sam Leffler" To: Cc: , , References: <26723.1046282534@critter.freebsd.dk> Subject: Re: cvs commit: src/sys/kern kern_time.c Date: Wed, 26 Feb 2003 10:46:11 -0800 Organization: Errno Consulting MIME-Version: 1.0 Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 5.50.4807.1700 X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4807.1700 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > In message <200302261716.h1QHGcpH094340@repoman.freebsd.org>, Sam Leffler write > s: > >sam 2003/02/26 09:16:38 PST > > > > Modified files: > > sys/kern kern_time.c > > Log: > > o fix ppsratecheck to interpret a maxpps of zero as "ignore everything" > > o add a comment explaining the significance of using 0 or -1 (actually > > any negative value) for maxpps > > Would it be possible to make some magic value mean "once" ? I'm sure it is possible, but I've boloxed this stuff enough right now so I'd prefer someone else do it. As it is ppsratecheck is not especially useful in the way I intended because it fixes the time interval at 1 second. The wi driver and probably other potential users would be better off with a mechanism that lets you rate limit over a longer interval (like 60 seconds). When I added this stuff I argued against a new API but now I'm thinking it might be better to just replace this with something entirely different. Sam To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message