From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Apr 30 05:50:22 2004 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5C01A16A4D0 for ; Fri, 30 Apr 2004 05:50:22 -0700 (PDT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2F9E443D39 for ; Fri, 30 Apr 2004 05:50:21 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) i3UCoLZE010377 for ; Fri, 30 Apr 2004 05:50:21 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i3UCoL5n010376; Fri, 30 Apr 2004 05:50:21 -0700 (PDT) (envelope-from gnats) Resent-Date: Fri, 30 Apr 2004 05:50:21 -0700 (PDT) Resent-Message-Id: <200404301250.i3UCoL5n010376@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Oliver Eikemeier Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BB2C416A4CE for ; Fri, 30 Apr 2004 05:45:24 -0700 (PDT) Received: from fillmore.dyndns.org (port-212-202-49-130.reverse.qsc.de [212.202.49.130]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6D6F443D2D for ; Fri, 30 Apr 2004 05:45:24 -0700 (PDT) (envelope-from eikemeier@fillmore-labs.com) Received: from [172.16.0.2] (helo=fillmore-labs.com) by fillmore.dyndns.org with esmtp (Exim 4.32; FreeBSD) id 1BJXOM-000MiG-0w for FreeBSD-gnats-submit@FreeBSD.org; Fri, 30 Apr 2004 14:45:23 +0200 Message-Id: <40924A63.9060107@fillmore-labs.com> Date: Fri, 30 Apr 2004 14:45:23 +0200 From: Oliver Eikemeier To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/66110: [PATCH] bsd.port.mk: MLINKS error detection is broken X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Apr 2004 12:50:22 -0000 >Number: 66110 >Category: ports >Synopsis: [PATCH] bsd.port.mk: inconsistent use of `::' targets >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Apr 30 05:50:20 PDT 2004 >Closed-Date: >Last-Modified: >Originator: Oliver Eikemeier >Release: FreeBSD 4.10-STABLE i386 >Organization: Fillmore Labs - http://www.fillmore-labs.com >Environment: System: FreeBSD nuuk.fillmore-labs.com 4.10-STABLE >Description: bsd.port.mk sets _TMLINKS to be empty only when _MLINKS is undefined. This causes errors in generate-plist if a wrong MLINKS definition is given, rendering the MLINKS check useless >How-To-Repeat: cd to any port without MLINKS and do make MLINKS=x >Fix: (patch from PR 66109 required) Index: bsd.port.mk =================================================================== RCS file: /home/ncvs/ports/Mk/bsd.port.mk,v retrieving revision 1.488 diff -u -r1.488 bsd.port.mk --- bsd.port.mk 19 Apr 2004 23:39:52 -0000 1.488 +++ bsd.port.mk 30 Apr 2004 12:37:35 -0000 @@ -2438,7 +2462,7 @@ .endfor -.if !defined(_MLINKS) +.if !defined(_TMLINKS) _TMLINKS= .endif >Release-Note: >Audit-Trail: >Unformatted: