From owner-freebsd-current@FreeBSD.ORG Fri May 29 14:29:41 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 89198106566C; Fri, 29 May 2009 14:29:41 +0000 (UTC) (envelope-from avg@freebsd.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id EBE2B8FC08; Fri, 29 May 2009 14:29:39 +0000 (UTC) (envelope-from avg@freebsd.org) Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua [212.40.38.101]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id RAA23224; Fri, 29 May 2009 17:15:33 +0300 (EEST) (envelope-from avg@freebsd.org) Message-ID: <4A1FEE04.1060202@freebsd.org> Date: Fri, 29 May 2009 17:15:32 +0300 From: Andriy Gapon User-Agent: Thunderbird 2.0.0.21 (X11/20090406) MIME-Version: 1.0 To: John Baldwin , Warner Losh , Robert Noland , Ariff Abdullah , Sam Leffler X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: freebsd-current@freebsd.org, Rui Paulo Subject: fixing kobj signatures X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 May 2009 14:29:41 -0000 I think I have completed fixing signatures of kobj method implementations in the whole head tree. The current diff here: http://people.freebsd.org/~avg/ It is quite arbitrarily split into the following files: kobj-agp.diff kobj-arm.diff kobj-linker.diff kobj-other.diff kobj-sound.diff Most of the changes are quite trivial but not all. o kobj-linker.diff - I am not sure if changing interface signature was a good idea. o kobj-sound.diff - this is a slightly updated version of the patch previously posted to multimedia ml; Ariff, could you please let me know about your plans with respect to 8.0 release? o kobj-arm.diff - it seems that npe_miibus_writereg in sys/arm/xscale/ixp425/if_npe.c) could now make use of non-void return type to properly report errors (XXX cases). But I am not sure if it is actually checked in the calling code (otherwise how does it work now?). Maybe there are more places like that. Please review the patch. I might have done something wrong, made some obvious mistake (like typo) or missed an opportunity to improve the code beyond mechanical changes. I tested the patch by enabling 'notyet' definition of KOBJMETHOD in kobj.h and building the following: all arm kernels (without modules), GENERIC kernels for all archs that have them (with modules), LINT kernels for all archs that have them (without modules). It is quite possible, of course, that some incorrect signatures were not found using the above build. For instance, in the code under some non-default option. But I think the number of such functions should be quite small and they should be trivial to fix later. I propose this patch for inclusion into the three before 8.0 freeze depending on response from Ariff. if this patch is not committed before 8.0 freeze (whole or any significant portion of the patch), then I'd like to request a branch under users/ where I could integrate this patch for future merging. -- Andriy Gapon