From owner-svn-src-all@FreeBSD.ORG Fri Apr 10 09:55:30 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 55FE81065673 for ; Fri, 10 Apr 2009 09:55:30 +0000 (UTC) (envelope-from christoph.mallon@gmx.de) Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by mx1.freebsd.org (Postfix) with SMTP id 9A8188FC13 for ; Fri, 10 Apr 2009 09:55:29 +0000 (UTC) (envelope-from christoph.mallon@gmx.de) Received: (qmail invoked by alias); 10 Apr 2009 09:55:28 -0000 Received: from p54A3ED4A.dip.t-dialin.net (EHLO tron.homeunix.org) [84.163.237.74] by mail.gmx.net (mp056) with SMTP; 10 Apr 2009 11:55:28 +0200 X-Authenticated: #1673122 X-Provags-ID: V01U2FsdGVkX19dpLZor5BdOCJ2UIIWGkld2gyp2+FtsX7cg8J/zl Nj6ltDDOB/cQqk Message-ID: <49DF178D.3000804@gmx.de> Date: Fri, 10 Apr 2009 11:55:25 +0200 From: Christoph Mallon User-Agent: Thunderbird 2.0.0.19 (X11/20090103) MIME-Version: 1.0 To: Ulf Lilleengen References: <200904100913.n3A9Dx2j037498@svn.freebsd.org> In-Reply-To: <200904100913.n3A9Dx2j037498@svn.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-FuHaFi: 0.7 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r190882 - head/sbin/gvinum X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Apr 2009 09:55:31 -0000 Ulf Lilleengen schrieb: > Author: lulf > Date: Fri Apr 10 09:13:58 2009 > New Revision: 190882 > URL: http://svn.freebsd.org/changeset/base/190882 > > Log: > - Move logic for finding a unique drive name into its own routine for future > code reuse. > > Modified: > head/sbin/gvinum/gvinum.c [...] > + /* Strip away eventual /dev/ in front. */ "eventual" does not mean what the author of this comment thought it means. "possible" would be more fitting here. Also "away" is a bit redundant. "/* Strip possible /dev/ in front. */" sounds better imo. Christoph