From owner-svn-src-head@FreeBSD.ORG Fri Jun 19 15:02:45 2015 Return-Path: Delivered-To: svn-src-head@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 48273EDE for ; Fri, 19 Jun 2015 15:02:45 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from nm27-vm1.bullet.mail.bf1.yahoo.com (nm27-vm1.bullet.mail.bf1.yahoo.com [98.139.213.148]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E445475D for ; Fri, 19 Jun 2015 15:02:44 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1434726157; bh=IxMjUjFMh9fFkL/8sDNquXx8zms5hl3sFX2wFv0bcRM=; h=Date:From:To:CC:Subject:References:In-Reply-To:From:Subject; b=E92iXXN8y9ZXrTa32HwBs63u3Kz/6cUdn/0rXqC5HKTbYuNLUtJ0opvT8OaP+69glUW/HzVs/DGyBXirolijVdhjdrSE16eJ73TNH8qoyLtJgR/+sCexK42c7JB5IfVSz5Aa2ZYEw2bMNREIw3bw1Nrg2qMfkXjHoZreFeaQe2lb12JIndzkcha3ckOqgBnhR0EQginySdN3tyhgSLi/1XtylyUyP3ccXaY7jAbHm16pNJ1msMcCWLdDhI5jrtqW4Q1TGZXcDhnaO836yvZS6yaQEAoW8lVZbDmT/YiSZO6N9vekKVO2wpKoBP8J+JCdksryqJE+ycyovwNw+zbSwg== Received: from [98.139.215.142] by nm27.bullet.mail.bf1.yahoo.com with NNFMP; 19 Jun 2015 15:02:37 -0000 Received: from [98.139.211.161] by tm13.bullet.mail.bf1.yahoo.com with NNFMP; 19 Jun 2015 15:02:37 -0000 Received: from [127.0.0.1] by smtp218.mail.bf1.yahoo.com with NNFMP; 19 Jun 2015 15:02:37 -0000 X-Yahoo-Newman-Id: 113467.43692.bm@smtp218.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: 47M3DksVM1nCtsM1wozJnVC8wLJ2PShrakD6i9o1nZ_Iq.k MAHvi8G5utYVIZyCIIui6m8r5Bbgl9C0jxG916OtkFkTK0YLUKWHMoriljA8 WJw6LRPnYoD_5P19hQJPx9o2L00udCxTm2zt0NV.7HJ93f._XOR0DOPBA2sT B5VmQswFnubWG7kuzPIutndkpHcDTA0qEb9tBtI.LSnyKwFa3q7e1ftlc1G9 A2U8FIVgFcZFUrr6XekNDUm4BWIx2dyvAzHHDEczwjr6bN85Ok9oMm1DLWBH U2YaA4nySjHpjUDfgcajUni1_sOUZVXoggVH2f5K33.DgcUILf8kzH1R0kmM WWA58mJI_JOx_PiTWprazig4Rt3lJZTcmbt4oQ54H22RJLA1.Tsqnzdeihtc 6nI1QPer0FDkfe.JM75Xn_mZSmjLRTyCzrnav4mk_T1RvpEfV0vd6uTLst0t YtautX8mkTqx4o5bLnvzIb_R1rVpP_EUvXa56SncXwC20LOzzSWIVF5RWHDO V78Oz59qJUiUVglo81hldf5elyrJgS1E5 X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Message-ID: <55842F16.5040608@FreeBSD.org> Date: Fri, 19 Jun 2015 10:02:46 -0500 From: Pedro Giffuni Organization: FreeBSD Project User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: David Chisnall CC: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r268137 - head/sys/sys References: <201407020845.s628jRG5031824@svn.freebsd.org> <5BE3492F-86A0-4CE3-A27C-8DB5EB662C64@FreeBSD.org> In-Reply-To: <5BE3492F-86A0-4CE3-A27C-8DB5EB662C64@FreeBSD.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jun 2015 15:02:45 -0000 Hello; Closely related to this, we are redefining _Noreturn, which is a reserved keyword in C11. Not sure what effect that mess causes. Pedro. On 19/06/2015 05:16 a.m., David Chisnall wrote: > I only just caught this (having seen the fallout from NetBSD doing the same thing in a shipping release and the pain that it’s caused): > > __weak is a reserved keyword in Objective-C, please pick another name for this. This in cdefs.h makes it impossible to include any FreeBSD standard headers in Objective-C programs (of which we have a couple of hundred in ports) if they use any of the modern Objective-C language modes. > > David > >> On 2 Jul 2014, at 09:45, Hans Petter Selasky wrote: >> >> Author: hselasky >> Date: Wed Jul 2 08:45:26 2014 >> New Revision: 268137 >> URL: http://svnweb.freebsd.org/changeset/base/268137 >> >> Log: >> Define a "__weak" macro for declaring symbols "weak". >> >> Modified: >> head/sys/sys/cdefs.h >> >> Modified: head/sys/sys/cdefs.h >> ============================================================================== >> --- head/sys/sys/cdefs.h Wed Jul 2 05:45:40 2014 (r268136) >> +++ head/sys/sys/cdefs.h Wed Jul 2 08:45:26 2014 (r268137) >> @@ -210,7 +210,9 @@ >> #define __packed >> #define __aligned(x) >> #define __section(x) >> +#define __weak >> #else >> +#define __weak __attribute__((__weak__)) >> #if !__GNUC_PREREQ__(2, 5) && !defined(__INTEL_COMPILER) >> #define __dead2 >> #define __pure2 >> >