From owner-freebsd-current@FreeBSD.ORG Tue Jun 26 14:04:05 2012 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 2FF041065702; Tue, 26 Jun 2012 14:04:05 +0000 (UTC) (envelope-from pawel@dawidek.net) Received: from mail.dawidek.net (60.wheelsystems.com [83.12.187.60]) by mx1.freebsd.org (Postfix) with ESMTP id CF7CC8FC14; Tue, 26 Jun 2012 14:04:04 +0000 (UTC) Received: from localhost (58.wheelsystems.com [83.12.187.58]) by mail.dawidek.net (Postfix) with ESMTPSA id D2F3E9C7; Tue, 26 Jun 2012 16:04:02 +0200 (CEST) Date: Tue, 26 Jun 2012 16:02:00 +0200 From: Pawel Jakub Dawidek To: "Andrey V. Elsukov" Message-ID: <20120626140200.GB1372@garage.freebsd.pl> References: <4FE9B01C.30306@yandex.ru> <20120626125737.GA1372@garage.freebsd.pl> <4FE9C0B6.5090106@yandex.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="XF85m9dhOBO43t/C" Content-Disposition: inline In-Reply-To: <4FE9C0B6.5090106@yandex.ru> X-OS: FreeBSD 10.0-CURRENT amd64 User-Agent: Mutt/1.5.21 (2010-09-15) Cc: freebsd-hackers , Doug Rabson , freebsd-current , Andriy Gapon Subject: Re: [CFC/CFT] large changes in the loader(8) code X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jun 2012 14:04:05 -0000 --XF85m9dhOBO43t/C Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 26, 2012 at 06:01:26PM +0400, Andrey V. Elsukov wrote: > On 26.06.2012 16:57, Pawel Jakub Dawidek wrote: > > On Tue, Jun 26, 2012 at 04:50:36PM +0400, Andrey V. Elsukov wrote: > >> Hi All, > >> > >> Some time ago i have started reading the code in the sys/boot. > >> Especially i'm interested in the partition tables handling. > >> I found several problems: > >> 1. There are several copies of the same code in the libi386/biosdisk.c > >> and common/disk.c, and partially libpc98/biosdisk.c. > >> 2. ZFS probing is very slow, because the ZFS code doesn't know how many > >> disks and partitions the system has: > >> http://www.freebsd.org/cgi/query-pr.cgi?pr=3D148296 > >> http://www.freebsd.org/cgi/query-pr.cgi?pr=3D161897 > >> 3. The GPT support doesn't check CRC and even doesn't know anything > >> about the secondary GPT header/table. > >=20 > > Just a quick note here. At some point when I was adding GPT attributes > > to allow for test starts I greatly improved, at least parts of, the GPT > > implementation. I did implement support for both CRC checksum > > verification and fallback to backup GPT header when primary is broken. > > And the code is still in sys/boot/common/gpt.c. So my question would be > > what do you mean by this sentence? >=20 > Yes, gptboot does that, but the loader/zfsloader doesn't. So there might > be a situation when gptboot does boot, but loader(8) can't. I see. I don't know if I'll find time for a proper review, but it is really great that you are working on cleaning up this huge mess. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://tupytaj.pl --XF85m9dhOBO43t/C Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAk/pwNgACgkQForvXbEpPzRNiACg9Jd2ghcjyMNO3acfJCWbqA5x CWIAoLBHIGoxWijoqp7QIb+fOtPETQj9 =+N3O -----END PGP SIGNATURE----- --XF85m9dhOBO43t/C--