From owner-svn-ports-all@freebsd.org Mon Mar 4 21:51:54 2019 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6300F1524700; Mon, 4 Mar 2019 21:51:54 +0000 (UTC) (envelope-from ngie@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 07EC98A35A; Mon, 4 Mar 2019 21:51:54 +0000 (UTC) (envelope-from ngie@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id F1A04A0FE; Mon, 4 Mar 2019 21:51:53 +0000 (UTC) (envelope-from ngie@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id x24LprKH090519; Mon, 4 Mar 2019 21:51:53 GMT (envelope-from ngie@FreeBSD.org) Received: (from ngie@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id x24LprRQ090518; Mon, 4 Mar 2019 21:51:53 GMT (envelope-from ngie@FreeBSD.org) Message-Id: <201903042151.x24LprRQ090518@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: ngie set sender to ngie@FreeBSD.org using -f From: Enji Cooper Date: Mon, 4 Mar 2019 21:51:53 +0000 (UTC) To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r494654 - head/devel/googletest X-SVN-Group: ports-head X-SVN-Commit-Author: ngie X-SVN-Commit-Paths: head/devel/googletest X-SVN-Commit-Revision: 494654 X-SVN-Commit-Repository: ports MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 07EC98A35A X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.97 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.97)[-0.972,0]; ASN(0.00)[asn:11403, ipnet:2610:1c1:1::/48, country:US]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Mar 2019 21:51:54 -0000 Author: ngie (src committer) Date: Mon Mar 4 21:51:53 2019 New Revision: 494654 URL: https://svnweb.freebsd.org/changeset/ports/494654 Log: devel/googletest: require libpthread As noted by @asomers in rS300906 (`cddl/usr.sbin/zfsd/tests/Makefile` specifically), googletest requires libpthread in order to function, if `-DGTEST_HAS_PTHREAD` is defined. While this is true, the code was not being linked against libpthread, resulting in libgtest being broken, and thus all tests reliant on the library broken at runtime. Adding `LIBS+= -lpthread` unbreaks the tests that use pthread support internally. PR: 236169 Reviewed by: jbeich Approved by: jbeich (maintainer) Differential Revision: https://reviews.freebsd.org/D19463 Modified: head/devel/googletest/Makefile Modified: head/devel/googletest/Makefile ============================================================================== --- head/devel/googletest/Makefile Mon Mar 4 21:47:09 2019 (r494653) +++ head/devel/googletest/Makefile Mon Mar 4 21:51:53 2019 (r494654) @@ -4,7 +4,7 @@ PORTNAME= googletest DISTVERSIONPREFIX= release- DISTVERSION= 1.8.1 -PORTREVISION= 1 +PORTREVISION= 2 CATEGORIES= devel MAINTAINER= jbeich@FreeBSD.org @@ -25,6 +25,12 @@ CONFIGURE_ENV= ac_cv_path_PYTHON=":" TEST_TARGET= check INSTALL_TARGET= install-strip USE_LDCONFIG= yes + +# googletest requires pthread in order to function and does not properly +# detect pthread support. +# +# See: https://github.com/google/googletest/issues/2162 +LIBS+= -lpthread post-patch: # enable vendor make install again (revert 661758e)