From owner-svn-src-head@freebsd.org  Sun Dec 27 19:16:54 2015
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 83874A53298
 for <svn-src-head@mailman.ysv.freebsd.org>;
 Sun, 27 Dec 2015 19:16:54 +0000 (UTC) (envelope-from ian@freebsd.org)
Received: from erouter6.ore.mailhop.org (erouter6.ore.mailhop.org
 [54.187.213.119])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 641D81889
 for <svn-src-head@freebsd.org>; Sun, 27 Dec 2015 19:16:54 +0000 (UTC)
 (envelope-from ian@freebsd.org)
Received: from ilsoft.org (unknown [73.34.117.227])
 by outbound3.ore.mailhop.org (Halon Mail Gateway) with ESMTPSA;
 Sun, 27 Dec 2015 19:16:15 +0000 (UTC)
Received: from rev (rev [172.22.42.240])
 by ilsoft.org (8.14.9/8.14.9) with ESMTP id tBRJGobM012426;
 Sun, 27 Dec 2015 12:16:50 -0700 (MST) (envelope-from ian@freebsd.org)
Message-ID: <1451243810.1369.10.camel@freebsd.org>
Subject: Re: svn commit: r292777 - in head: lib/libc/sys sys/kern
From: Ian Lepore <ian@freebsd.org>
To: Slawa Olhovchenkov <slw@zxy.spb.ru>
Cc: Dmitry Chagin <dchagin@FreeBSD.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
Date: Sun, 27 Dec 2015 12:16:50 -0700
In-Reply-To: <20151227184101.GG70867@zxy.spb.ru>
References: <201512271537.tBRFb7nN095297@repo.freebsd.org>
 <1451236237.1369.9.camel@freebsd.org> <20151227184101.GG70867@zxy.spb.ru>
Content-Type: text/plain; charset="us-ascii"
X-Mailer: Evolution 3.16.5 FreeBSD GNOME Team Port 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 27 Dec 2015 19:16:54 -0000

On Sun, 2015-12-27 at 21:41 +0300, Slawa Olhovchenkov wrote:
> On Sun, Dec 27, 2015 at 10:10:37AM -0700, Ian Lepore wrote:
> 
> > On Sun, 2015-12-27 at 15:37 +0000, Dmitry Chagin wrote:
> > > Author: dchagin
> > > Date: Sun Dec 27 15:37:07 2015
> > > New Revision: 292777
> > > URL: https://svnweb.freebsd.org/changeset/base/292777
> > > 
> > > Log:
> > >   Verify that tv_sec value specified in settimeofday() and
> > > clock_settime()
> > >   (CLOCK_REALTIME case) system calls is non negative.
> > >   This commit hides a kernel panic in atrtc_settime() as the
> > > clock_ts_to_ct()
> > >   does not properly convert negative tv_sec.
> > >   
> > >   ps. in my opinion clock_ts_to_ct() should be rewritten to
> > > properly
> > > handle
> > >   negative tv_sec values.
> > >   
> > >   Differential Revision:	https://reviews.freebsd.org/D4714
> > >   Reviewed by:		kib
> > >   
> > >   MFC after:	1 week
> > 
> > IMO, this change is completely unacceptable.  If there is a bug in
> > atrtc code, then by all means fix it, but preventing anyone from
> > setting valid time values on the system because one driver's code
> > can't
> > handle it is just wrong.
> 
> You talk about kernel panic when internal data structures not
> destructed is normal behavior? Realy?
> 

I have no idea what you mean by that -- I didn't say anything at all
about panic.

-- Ian