From owner-svn-src-head@freebsd.org Mon Mar 9 13:46:26 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id EB6A0262F12; Mon, 9 Mar 2020 13:46:26 +0000 (UTC) (envelope-from gallatin@cs.duke.edu) Received: from duke.cs.duke.edu (duke.cs.duke.edu [152.3.140.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 48bfdY1nV7z44xZ; Mon, 9 Mar 2020 13:46:24 +0000 (UTC) (envelope-from gallatin@cs.duke.edu) Received: from [192.168.1.2] (pool-74-110-182-118.rcmdva.fios.verizon.net [74.110.182.118]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: gallatin) by duke.cs.duke.edu (Postfix) with ESMTPSA id 824B627002E1; Mon, 9 Mar 2020 09:46:22 -0400 (EDT) DMARC-Filter: OpenDMARC Filter v1.3.1 duke.cs.duke.edu 824B627002E1 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=cs.duke.edu; s=mail0816; t=1583761582; bh=MZmV1UByt+s5FU5VOFGst32Di6K0kuFZHWE9lki/uJY=; h=Subject:To:From:Date:From; b=UbkKQEcMn4Wg+WBgcsvc2+pKG3DUgpXOGhQYpjgYhbJICWFh6mQ1ywbqK1AkDbe8h gtK2ifaPonBmumyvLknz3u7eU4KLpwqVOuvG0XeT1DwkaKPNfwo7PB5ZEDpZHh57tV Www2mq1B3pPtMh6/nUMsUSiUAr5uY1+Rk6YgnpIb+ORldpQVVgjHCGbkyNK0LpZi92 tHwY3Pw7HCpF9DpF6v9WeTanKEQ0OlLqaCswvvCY3BYd0wrWOQTFE+M+WdeVGsi/1k NBDpmQAgR7osuuz4Ls7Y0ppz+ziD5gzIwlTPxeZlnmCqip4Ml7NA6tb8BqaPb3dl5m C/gBBrehI6PNg== Subject: Re: svn commit: r358808 - in head/sys: kern net netinet To: Andrew Gallatin , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <202003091344.029Dipuf016764@repo.freebsd.org> From: Andrew Gallatin Message-ID: Date: Mon, 9 Mar 2020 09:46:21 -0400 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <202003091344.029Dipuf016764@repo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 48bfdY1nV7z44xZ X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.03 / 15.00]; REPLY(-4.00)[]; NEURAL_SPAM_MEDIUM(0.97)[0.969,0]; NEURAL_HAM_LONG(-0.99)[-0.994,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Mar 2020 13:46:27 -0000 On 2020-03-09 09:44, Andrew Gallatin wrote: > Author: gallatin > Date: Mon Mar 9 13:44:51 2020 > New Revision: 358808 > URL: https://urldefense.com/v3/__https://svnweb.freebsd.org/changeset/base/358808__;!!OToaGQ!5mmRl2ROq7G4c4x2Xe2uHppYyETGlCRsREj-jHw0ZWcNqt3GhQju3BHBkM_vsrVvkQ$ > > Log: > make lacp's use_numa hashing aware of send tags > > When I did the use_numa support, I missed the fact that there is > a separate hash function for send tag nic selection. So when > use_numa is enabled, ktls offload does not work properly, as it > does not reliably allocate a send tag on the proper egress nic > since different egress nics are selected for send-tag allocation > and packet transmit. To fix this, this change: > > - refectors lacp_select_tx_port_by_hash() and > lacp_select_tx_port() to make lacp_select_tx_port_by_hash() > always called by lacp_select_tx_port() > > - pre-shifts flowids to convert them to hashes when calling lacp_select_tx_port_by_hash() > > - adds a numa_domain field to if_snd_tag_alloc_params > > - plumbs the numa domain into places where we allocate send tags > > In testing with NIC TLS setup on a NUMA machine, I see thousands > of output errors before the change when enabling > kern.ipc.tls.ifnet.permitted=1. After the change, I see no > errors, and I see the NIC sysctl counters showing active TLS > offload sessions. > > Reviewed by: rrs, hselasky, jhb > Sponsored by: Netflix Forgot: Differential: https://reviews.freebsd.org/D23811