From owner-cvs-all Fri Jun 15 8:51:27 2001 Delivered-To: cvs-all@freebsd.org Received: from ringworld.nanolink.com (ringworld.nanolink.com [195.24.48.13]) by hub.freebsd.org (Postfix) with SMTP id 4775037B419 for ; Fri, 15 Jun 2001 08:51:09 -0700 (PDT) (envelope-from roam@orbitel.bg) Received: (qmail 39709 invoked by uid 1000); 15 Jun 2001 15:49:44 -0000 Date: Fri, 15 Jun 2001 18:49:44 +0300 From: Peter Pentchev To: Bruce Evans Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/rarpd rarpd.c Message-ID: <20010615184944.L94445@ringworld.oblivion.bg> Mail-Followup-To: Bruce Evans , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org References: <200106131156.f5DBu0o86165@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200106131156.f5DBu0o86165@freefall.freebsd.org>; from bde@FreeBSD.org on Wed, Jun 13, 2001 at 04:56:00AM -0700 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, Jun 13, 2001 at 04:56:00AM -0700, Bruce Evans wrote: > bde 2001/06/13 04:56:00 PDT > > Modified files: > usr.sbin/rarpd rarpd.c > Log: > Fixed world breakage on systems where ntohl() doesn't return u_long > (e.g., on alphas, or even on i386's with a POSIX-200x-conformant > ntohl() (ntohl() returns uint32_t which is u_int on i386's)). > > Fixed related bugs and bogons while I'm here: > - ntohl() was "fixed" for printing in 1 place by casting to > "(unsigned int )". This breaks the value on systems where u_int > is smaller than uint32_t, and has 2 style bugs. > - spell u_int consistently (never use "unsigned"). > - break K&R support some more (don't cast malloc()'s arg to a wrong > type...). Ehhh.. oops! Thanks, and sorry! (really, it's about time for me to start bugging my employer to get me an Alpha for R&D purposes.. :) G'luck, Peter -- Nostalgia ain't what it used to be. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message