From owner-svn-src-head@freebsd.org Wed Apr 20 14:33:05 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 68100B16BC8 for ; Wed, 20 Apr 2016 14:33:05 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from nm13-vm0.bullet.mail.bf1.yahoo.com (nm13-vm0.bullet.mail.bf1.yahoo.com [98.139.213.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 08AF0135D for ; Wed, 20 Apr 2016 14:33:04 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1461162782; bh=tRrboU9+lnI7mUlC3o4xNws6BsUgrnR7SaPgsGwOxy8=; h=Subject:To:References:Cc:From:Date:In-Reply-To:From:Subject; b=WoSEtsg/5OFs+F+vj/jBpDoqRxOLEXgUOwi38R0ave+rg4gf9rh8ObjouDO/kd2Wlcjp9OVB9qdroSOMcNTx8qDWcmQ76UCFlBaW/kMAgKoaCztT+vGxpkLRGnlvyfPjutE9r5EpSheBMaPngj6r/jJevmbesOrhfFBN69J/KNardePWeoEuEAwc6Tm1FarMvUYeV9HSMWpnRbmYeQyHTaoVctgAs7QWsxhf3PQ0cFaoR2PH8sYpvUOdCIivaYOGl7eNGywsGqNc6qvMGOf9kOtUuAGqa63R7vQTu3zAnkRiiXVTDXCLu+dboPnsosndrgzVsILWAB1W7D5ZU8hvjw== Received: from [98.139.215.140] by nm13.bullet.mail.bf1.yahoo.com with NNFMP; 20 Apr 2016 14:33:02 -0000 Received: from [98.139.213.9] by tm11.bullet.mail.bf1.yahoo.com with NNFMP; 20 Apr 2016 14:33:02 -0000 Received: from [127.0.0.1] by smtp109.mail.bf1.yahoo.com with NNFMP; 20 Apr 2016 14:33:02 -0000 X-Yahoo-Newman-Id: 811760.34204.bm@smtp109.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: 7.pKa.EVM1lEbcaMg8a73isXdz6wbBTqD3s6yoGgupoqC9X ChCS2PzUJEwjwcv1hi57X2CARmvINIAi_cVWahDNuxQ2x6CbXLq9nO9fuGrl JPB6sxuGrEad0nLgolozprtCvHJ.NRdwk.hkhhLaXsBF6fLD1srQD59er7EP 4crT5MlpZWyfdXR.vV5ZnlvsytmFwZVNaq3sGF2pjICJXrhZxsqcJGma2Dvk 2i4V_WoxBRobVVBhH6bvifdWDz7DBnQxey7fpjGnl7nE6pGaq3X772NM6ouY qzjwKrFsauaSECGx3wHAmi.aO7hMbaz8_PBO2fBQnsIhSJ1.3yBA.TfbR3Us yLOhgQUPOrwyAzf0NU4fJC6YuNKPjcOAmqoyesQSgk.sn74XvPMaByvBUYki iu2_Xiq0k614rsFyKH9dhuJe8CWXh7kK7ajyWi1n6bimI0PNYvlVn3mWqdzL rLxyV.CqrIGbu71IjHaKUoYGRW5hOnMV9rEXQJPonu6_DfGN0xoGQMKEqFJ7 nbnUBvZWuH.TtfBqT_rRKwOz3Trr6.cJ9 X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Subject: Re: svn commit: r298247 - head/sbin/fdisk_pc98 To: Bruce Evans , araujo@freebsd.org References: <201604190446.u3J4kD9G050780@repo.freebsd.org> <4114217.PtcV9LDMal@ralph.baldwin.cx> <20160420115844.Y967@besplex.bde.org> Cc: John Baldwin , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" From: Pedro Giffuni Message-ID: Date: Wed, 20 Apr 2016 09:33:07 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <20160420115844.Y967@besplex.bde.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Apr 2016 14:33:05 -0000 On 04/19/16 22:06, Bruce Evans wrote: > On Wed, 20 Apr 2016, Marcelo Araujo wrote: > >> 2016-04-20 0:16 GMT+08:00 John Baldwin : >> >>> On Tuesday, April 19, 2016 04:46:13 AM Marcelo Araujo wrote: >>>> Author: araujo >>>> Date: Tue Apr 19 04:46:13 2016 >>>> New Revision: 298247 >>>> URL: https://svnweb.freebsd.org/changeset/base/298247 >>>> >>>> Log: >>>> Remove redundant parenthesis. >>>> >>>> Submitted by: pfg >>>> MFC after: 2 weeks. > > I don't realling like churnging to the nonstandard nitems(). Use > of the nonstandard is bad enough. > TBH, I am not joyful about them either, however it does improve readability so it makes sense only in the cases where sys/param.h is already in use. One of the things I dislike is that most of the macros are in lowercase. Lowercase would make sense if these were inline functions but inline functions have disadvantages for these use cases. OTOH, if they were uppercase, they would not be very easy on the eyes, which is the current advantage. No way out of it :(. Pedro.