From owner-cvs-all@FreeBSD.ORG Fri Jun 22 13:22:37 2007 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id BA5DA16A400; Fri, 22 Jun 2007 13:22:37 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id ADC1913C458; Fri, 22 Jun 2007 13:22:37 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l5MDMbw0063576; Fri, 22 Jun 2007 13:22:37 GMT (envelope-from kib@repoman.freebsd.org) Received: (from kib@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l5MDMbZX063575; Fri, 22 Jun 2007 13:22:37 GMT (envelope-from kib) Message-Id: <200706221322.l5MDMbZX063575@repoman.freebsd.org> From: Konstantin Belousov Date: Fri, 22 Jun 2007 13:22:37 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/ufs/ffs ffs_softdep.c src/sys/ufs/ufs ufs_inode.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jun 2007 13:22:37 -0000 kib 2007-06-22 13:22:37 UTC FreeBSD src repository Modified files: sys/ufs/ffs ffs_softdep.c sys/ufs/ufs ufs_inode.c Log: Fix livelock that could occur when snapshoting UFS with quotas, where some quota limit was exceeded. Sequence of UFS_VALLOC()/UFS_VFREE() call there could cause inodeblock to have both freefile and inodedep dependencies without any inode in the block being marked for write. Then, softdep_check_suspend() would return EAGAIN forewer. Force write of inodeblock with allocated freefile softdependency by setting IN_MODIFIED flag in softdep_freefile and unconditionally calling UFS_UPDATE() in ufs_reclaim. Reported by: kris Debug help and tested by: Peter Holm Approved by: re (kensmith) MFC after: 3 weeks Revision Changes Path 1.211 +1 -0 src/sys/ufs/ffs/ffs_softdep.c 1.69 +2 -3 src/sys/ufs/ufs/ufs_inode.c