From owner-cvs-all Fri Jan 14 12:18:44 2000 Delivered-To: cvs-all@freebsd.org Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by hub.freebsd.org (Postfix) with ESMTP id BDAC115288; Fri, 14 Jan 2000 12:18:34 -0800 (PST) (envelope-from bde@zeta.org.au) Received: from bde.zeta.org.au (beefcake.zeta.org.au [203.26.10.12]) by mailman.zeta.org.au (8.8.7/8.8.7) with ESMTP id HAA10647; Sat, 15 Jan 2000 07:18:16 +1100 Date: Sat, 15 Jan 2000 07:18:12 +1100 (EST) From: Bruce Evans X-Sender: bde@alphplex.bde.org To: Jason Evans Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern init_sysent.c sys_generic.c syscalls.c syscalls.master uipc_socket.c uipc_socket2.c vfs_aio.c src/sys/sys aio.h socketvar.h syscall-hide.h syscall.h syscall.mk sysproto.h In-Reply-To: <20000114105513.O302@sturm.canonware.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk On Fri, 14 Jan 2000, Jason Evans wrote: > On Sat, Jan 15, 2000 at 01:14:09AM +1100, Bruce Evans wrote: > > Don't mix style fixes with new functionality. It makes the diffs hard to > > ... > > Okay, that makes sense. So the next time this comes up, should I check in > the style changes before or after the functionality changes? After is usually a little better. E.g., the new features may need to be back-ported and you may not want to back-port the cleanups. This applies more to fixes than new features. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message