Date: Fri, 02 Dec 2011 08:30:18 -0500 From: Ken Smith <kensmith@FreeBSD.org> To: Erik Cederstrand <erik@cederstrand.dk> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Robert Watson <rwatson@FreeBSD.org>, Joel Dahl <joel@FreeBSD.org> Subject: Re: svn commit: r228192 - head/usr.sbin/bsdinstall/scripts Message-ID: <1322832618.99806.8.camel@bauer.cse.buffalo.edu> In-Reply-To: <08BC9075-C4E8-4156-BAAF-C097B118B7B4@cederstrand.dk> References: <201112020038.pB20cmt6068628@svn.freebsd.org> <20111202094411.GJ23987@goofy01.vnodelab.local> <08BC9075-C4E8-4156-BAAF-C097B118B7B4@cederstrand.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-JYpl3mggHpnXr7S1H54e Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On Fri, 2011-12-02 at 14:18 +0100, Erik Cederstrand wrote: > Den 02/12/2011 kl. 10.44 skrev Joel Dahl: >=20 > > On 02-12-2011 0:38, Ken Smith wrote: > >> Author: kensmith > >> Date: Fri Dec 2 00:38:47 2011 > >> New Revision: 228192 > >> URL: http://svn.freebsd.org/changeset/base/228192 > >>=20 > >> Log: > >> Add a screen that asks if the user would like to enable crash dumps, > >> giving them a very brief description of the trade-offs. Whether the > >> user opts in or out add an entry to what will become /etc/rc.conf > >> explaining what dumpdev is and how to turn on/off crash dumps. The f= olks > >> who handle interacting with users submitting PRs have asked for this. > >=20 > > Hmm. Two things I'd like to bring up: > >=20 > > * Not specifically aimed at this commit, but my recommendation > > would be that we keep bsdinstall as simple as possible: installing Fre= eBSD > > should require a minimum amount of keystrokes. I realise this is just = one > > more screen, but I hope we don't turn bsdinstall into a configuration > > utility where you can disable/enable just about anything in rc.conf. > >=20 > > * Mentioning future system crashes during installation feels awkward. I= s that > > really what we want? I understand the problem and how this helps us wi= th > > debugging, but this is like saying to users that what they are install= ing > > is unstable and that it'll eventuelly crash and die. I know we discuss= ed > > ways of making crash dumps smarter in order to not fill up /var, which= in > > turn would allow us to always have it on. Maybe that is the right path= ? >=20 > Maybe do away with the dialog, and then unconditionally enable textdump i= n rc.conf, adding the magic so textdump_enable=3D"YES" sets up textdump wit= h sane defaults. >=20 > Thanks, > Erik >=20 This just implements what we seemed to settle on during the latest round of several discussions we've had about this issue. It comes up each I've turned off dumpdev as part of converting head into a stable branch, which is a step that got started way before I started being the one to do it. I'll be happy to see what I just added go away but the pre-condition for that is infrastructure that prevents crash dumps (of any form, including textdumps) from filling up /var if the user turns out to be clueless about them and doesn't realize they should pay attention to them. At least as of the last time we discussed it this knob I just added is a compromise between people who worry about crash dumps going unattended and filling /var versus the people who want us to be able to collect debugging information from the users who submit PRs *and* provide an *extremely* easy way for said users to turn it on/off. I normally hate dragging what others do into the discussions but I know of several Linux's that offer to enable kdump in their installer so we're not alone in that regard. --=20 Ken Smith - From there to here, from here to | kensmith@freebsd.org there, funny things are everywhere. | - Theodor Geisel | --=-JYpl3mggHpnXr7S1H54e Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEABECAAYFAk7Y0t4ACgkQ/G14VSmup/a+IQCaAiK/zglIs/hNew1qyyvcr03E Nz4An2LpCKD4cIb2JSUVqJF3ZioyovdX =OOzY -----END PGP SIGNATURE----- --=-JYpl3mggHpnXr7S1H54e--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1322832618.99806.8.camel>