From owner-cvs-all@FreeBSD.ORG  Thu Mar 22 10:06:25 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 3121F16A4D1
	for <cvs-all@FreeBSD.org>; Thu, 22 Mar 2007 10:06:25 +0000 (UTC)
	(envelope-from LoN_Kamikaze@gmx.de)
Received: from mail.gmx.net (mail.gmx.net [213.165.64.20])
	by mx1.freebsd.org (Postfix) with SMTP id 76FA713C48A
	for <cvs-all@FreeBSD.org>; Thu, 22 Mar 2007 10:06:24 +0000 (UTC)
	(envelope-from LoN_Kamikaze@gmx.de)
Received: (qmail invoked by alias); 22 Mar 2007 09:39:43 -0000
Received: from vpn-cl-160-173.rz.uni-karlsruhe.de (EHLO [141.3.160.173])
	[141.3.160.173]
	by mail.gmx.net (mp052) with SMTP; 22 Mar 2007 10:39:43 +0100
X-Authenticated: #5465401
X-Provags-ID: V01U2FsdGVkX190e9Uniq90211XFmU94Nts3S8C7kJwYVuy32V+f0
	bzHcWm6GeXmqRU
Message-ID: <46024F11.1040600@gmx.de>
Date: Thu, 22 Mar 2007 10:40:33 +0100
From: "[LoN]Kamikaze" <LoN_Kamikaze@gmx.de>
User-Agent: Thunderbird 1.5.0.10 (X11/20070314)
MIME-Version: 1.0
To: Doug Barton <dougb@FreeBSD.org>
References: <200702261857.l1QIvVMT051664@repoman.freebsd.org>
	<45E3701E.9000900@FreeBSD.org>
In-Reply-To: <45E3701E.9000900@FreeBSD.org>
X-Enigmail-Version: 0.94.0.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Y-GMX-Trusted: 0
Cc: cvs-all@FreeBSD.org, ports-committers@FreeBSD.org,
	Gabor Kovesdan <gabor@FreeBSD.org>, cvs-ports@FreeBSD.org,
	erwin@freebsd.org, Christian Lackas <delta@lackas.net>
Subject: Re: cvs commit: ports/security/vpnc Makefile
 ports/security/vpnc/files vpnc.in vpnc.sh
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Mar 2007 10:06:25 -0000

Doug Barton wrote:
> 5. In vpnc_start() you could simplify the code by doing:
> 
> if ! $command $current $vpnc_flags; then
> 	status=$?
> 	echo "Running 'vpnc $current $vpnc_flags' failed."
> 	return $status
> fi

That was a really bad idea, because it causes status to always be 0. Which is probably not the right thing to return in case of an error.