From nobody Tue Mar 21 23:28:09 2023 X-Original-To: testing@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Ph77t1Qlhz40ylY for ; Tue, 21 Mar 2023 23:28:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Ph77t0K7Vz4LTn for ; Tue, 21 Mar 2023 23:28:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1679441290; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fCJS8yB0ED+HsbZvmaFcrosUybQPwzh9GluryH6CBhY=; b=rEkm5tRYK26WSR5zW6e2C+MDAcXctACnd745AyzVjEr4FclJUDmEl8CO+t2q8hK5G2Pwzd vyUK7RCkGJJ+4+tyqoJt7lHlrZAURnbJa/QUHj8+teNPwbVQM+mUCtcqWjrV273zmaM4cz zhdP/NqqdlvObbk5uJRiPg17z6IWkLDAXzd73y++dM2YXe8a5mdbpFqcF33sOBjDa0QO3p hlPBhIzV4ENrd5XJXMnIu6VJA5Oqcq0RfzgREe1ZUomdrptCRgISGl6nImuGMtr9YyIJ3j 2xF4NT+oCDLNuPR6c1zKXhImXJMTUJohkDiWwtHdwFXp662aEDf6kh3UQIKXYQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1679441290; a=rsa-sha256; cv=none; b=yClZFpgcMyU1gy1AXjRrOpGmJXKo3RYqTcJ3nuUwzR/RJnjbDrN5kc7Y3JqkRPkAX+lnt+ xdg1XSKA3LTq12mrdgbNpfFUUc8gyvKt6l/tORe7uDqjb/acyFun535vQ1vZ5zhBo2NGb6 tNKsCPcFI2m0uHriN+gjJ7XGtk5ILix+jsUCMV0X7BUeKDVX/U2tlCuhCIUqHfso8YcKVp behjojTEpor2QAvn3WypFJfGmDDvEPZtibr/tyJLWSTmCvKD7fu0ZkhbuRfhW47ynpB/Bz 1kMOZ0LsF/ekZWOzX/SCGO/6pyiMzTy3rwyS/283xjhWY9YZcu/0M0Wr/UiBog== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Ph77s6Wg0zWlY for ; Tue, 21 Mar 2023 23:28:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 32LNS9XG069016 for ; Tue, 21 Mar 2023 23:28:09 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 32LNS97d069015 for testing@FreeBSD.org; Tue, 21 Mar 2023 23:28:09 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: testing@FreeBSD.org Subject: [Bug 260547] sys.netmap.ctrl-api-test.main fails in CI Date: Tue, 21 Mar 2023 23:28:09 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: tests X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: testing@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Testing List-Archive: https://lists.freebsd.org/archives/freebsd-testing List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-testing@freebsd.org X-BeenThere: freebsd-testing@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D260547 --- Comment #10 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3De2a431a0ffb6894220bdf5d8fc2ca2d0c= a316e85 commit e2a431a0ffb6894220bdf5d8fc2ca2d0ca316e85 Author: Vincenzo Maffione AuthorDate: 2023-03-21 23:23:18 +0000 Commit: Vincenzo Maffione CommitDate: 2023-03-21 23:23:18 +0000 netmap: fix copyin/copyout of nmreq options list The previous code unsuccesfully attempted to report a precise error for each option in the user list. Moreover, commit 253b2ec199b broke some ctrl-api-test (see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D260547). With this patch we bail out as soon as an unrecoverable error is detect= ed and we properly check for copy boundaries. EOPNOTSUPP no longer immediately returns an error, so that any other option in the list may be examined by the caller code and a precise report of the (un)supported options can be returned to the user. With this patch, all ctrl-api-test unit tests pass again. PR: 260547 Submitted by: giuseppe.lettieri@unipi.it Reviewed by: vmaffione MFC after: 14 days sys/dev/netmap/netmap.c | 69 ++++++++++++++++++++++++------------= ---- tests/sys/netmap/ctrl-api-test.c | 23 ++++++++++++-- 2 files changed, 63 insertions(+), 29 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=