From owner-svn-src-all@FreeBSD.ORG  Wed Feb 25 20:52:55 2009
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A8F41106564A;
	Wed, 25 Feb 2009 20:52:54 +0000 (UTC) (envelope-from ed@hoeg.nl)
Received: from palm.hoeg.nl (mx0.hoeg.nl [IPv6:2001:7b8:613:100::211])
	by mx1.freebsd.org (Postfix) with ESMTP id 6A5128FC18;
	Wed, 25 Feb 2009 20:52:54 +0000 (UTC) (envelope-from ed@hoeg.nl)
Received: by palm.hoeg.nl (Postfix, from userid 1000)
	id A5C381CDE5; Wed, 25 Feb 2009 21:52:53 +0100 (CET)
Date: Wed, 25 Feb 2009 21:52:53 +0100
From: Ed Schouten <ed@80386.nl>
To: Robert Noland <rnoland@FreeBSD.org>
Message-ID: <20090225205253.GT19161@hoeg.nl>
References: <200902251854.n1PIsZZP005285@svn.freebsd.org>
	<20090225194228.GS19161@hoeg.nl>
	<1235593885.1273.80.camel@widget.2hip.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="rE45P3aZNSuYx5ND"
Content-Disposition: inline
In-Reply-To: <1235593885.1273.80.camel@widget.2hip.net>
User-Agent: Mutt/1.5.19 (2009-01-05)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r189052 - head/sys/dev/drm
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Feb 2009 20:52:56 -0000


--rE45P3aZNSuYx5ND
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

* Robert Noland <rnoland@FreeBSD.org> wrote:
> On Wed, 2009-02-25 at 20:42 +0100, Ed Schouten wrote:
> > Hi Robert,
> >=20
> > * Robert Noland <rnoland@FreeBSD.org> wrote:
> > > +static struct drm_msi_blacklist_entry drm_msi_blacklist[] =3D {
> > > +	{0x8086, 0x2772}, /* Intel i945G	*/ \
> > > +	{0x8086, 0x27A2}, /* Intel i945GM	*/ \
> > > +	{0x8086, 0x27AE}, /* Intel i945GME	*/ \
> > > +	{0, 0}
> > > +};
> >=20
> > Wouldn't it be better to use PCI_VENDOR_INTEL/PCI_PRODUCT_INTEL_*
> > definitions here?
>=20
> Where are those located?  The rest of drm just uses the hex id's, if
> there is a better way, I'm up for it.

Oh wait, I always thought they were part of some kind of central list,
like usbdevs, but it turns out device drivers just #define them
themselves. Never mind.

--=20
 Ed Schouten <ed@80386.nl>
 WWW: http://80386.nl/

--rE45P3aZNSuYx5ND
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (FreeBSD)

iEYEARECAAYFAkmlr6UACgkQ52SDGA2eCwWGewCffM2om+1yKrZLz00nboWoEosK
u0oAnjPFqRRqsmweKvf7HfHOxaOaQ9E9
=6N9f
-----END PGP SIGNATURE-----

--rE45P3aZNSuYx5ND--