From owner-cvs-src@FreeBSD.ORG Mon Aug 21 12:16:17 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 53CB416A4DA; Mon, 21 Aug 2006 12:16:17 +0000 (UTC) (envelope-from flz@FreeBSD.org) Received: from smtp3-g19.free.fr (smtp3-g19.free.fr [212.27.42.29]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8E4A343D45; Mon, 21 Aug 2006 12:16:16 +0000 (GMT) (envelope-from flz@FreeBSD.org) Received: from smtp.xbsd.org (unknown [82.233.2.192]) by smtp3-g19.free.fr (Postfix) with ESMTP id D64C449453; Mon, 21 Aug 2006 14:16:15 +0200 (CEST) Received: from localhost (localhost.xbsd.org [127.0.0.1]) by smtp.xbsd.org (Postfix) with ESMTP id 3D84C115E3; Mon, 21 Aug 2006 14:16:15 +0200 (CEST) Received: from smtp.xbsd.org ([127.0.0.1]) by localhost (srv1.xbsd.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 26951-09; Mon, 21 Aug 2006 14:16:09 +0200 (CEST) Received: from mayday.esat.net (mayday.esat.net [193.95.134.156]) by smtp.xbsd.org (Postfix) with ESMTP id 33D9311415; Mon, 21 Aug 2006 14:16:07 +0200 (CEST) From: Florent Thoumie To: Kris Kennaway In-Reply-To: <20060821115657.GA1425@xor.obsecurity.org> References: <200601161951.k0GJpfNx017833@repoman.freebsd.org> <20060821080945.A48690@p-i-n.com> <20060821110753.GA99959@xor.obsecurity.org> <1156159640.53353.29.camel@mayday.esat.net> <20060821115657.GA1425@xor.obsecurity.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-qyEeAxUdC7OE8ukB1AkV" Date: Mon, 21 Aug 2006 13:16:22 +0100 Message-Id: <1156162582.53353.37.camel@mayday.esat.net> Mime-Version: 1.0 X-Mailer: Evolution 2.6.3 FreeBSD GNOME Team Port X-Virus-Scanned: amavisd-new at xbsd.org Cc: cvs-src@freebsd.org, src-committers@freebsd.org, "Raphael H. Becker" , cvs-all@freebsd.org Subject: Re: PKGDIR ambiguous (was: cvs commit: src/usr.sbin/pkg_install/info info.h main.c perform.c pkg_info.1 src/usr.sbin/pkg_install/add add.h main.c perform.c pkg_add.1 src/usr.sbin/pkg_install/lib lib.h url.c) X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Aug 2006 12:16:17 -0000 --=-qyEeAxUdC7OE8ukB1AkV Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Mon, 2006-08-21 at 07:56 -0400, Kris Kennaway wrote: > On Mon, Aug 21, 2006 at 12:27:20PM +0100, Florent Thoumie wrote: > > On Mon, 2006-08-21 at 07:07 -0400, Kris Kennaway wrote: > > > On Mon, Aug 21, 2006 at 08:09:45AM +0200, Raphael H. Becker wrote: > > > >=20 > > > > Hi Florent, > > > >=20 > > > > PKGDIR is ambiguous in the context of ports and packages. > > > >=20 > > > > I set PKGDIR=3D/some/where/my/pkg in my /etc/profile which causes t= he > > > > ports to fail badly creating any packages: > > > >=20 > > > > It is used in ports/Mk/bsd.port.mk: > > > > # PKGDIR - A directory containing any package creati= on > > > > # files. > > > > # Default: ${MASTERDIR} > > > > [...] > > > > PKGDIR?=3D ${MASTERDIR} > > > >=20 > > > > Havin set PKGDIR statically is a very bad idea here. > > >=20 > > > Yes, PKGDIR is incorrect in this usage. The documented place where > > > packages are stored is: > > >=20 > > > # PACKAGES - A top level directory where all packages go= (rather than > > > # going locally to each port). > > > # Default: ${PORTSDIR}/packages > > > # > >=20 > > PACKAGES is a better choice than PKGDIR, but I'd like to avoid confusio= n > > between "cached" packages (as in, copies of downloaded packages), and > > "home-brewed" packages.=20 >=20 > Not sure there is a need to; they're both just packages. I think there is, or there should be another subdirectory under PACKAGES to tell where the packages come from. Like what apt does, something like ${PACKAGES}/ftp.freebsd.org.packages.6.stable/All/blah.tbz. You definitely don't want to mix packages from different sources, or made from different ports trees. > > That's why I was proposing PKG_CACHEDIR. > >=20 > > Moreover, I think there's no easy way to find the category of a package > > before it is downloaded. >=20 > You don't need to, you can download it to All/, and then postprocess. Right. --=20 Florent Thoumie flz@FreeBSD.org FreeBSD Committer --=-qyEeAxUdC7OE8ukB1AkV Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.4 (FreeBSD) iD8DBQBE6aQWMxEkbVFH3PQRAoqgAJ9q2Qi39rSJyMS8RF/HsDUa7R1+HgCfe9ep 5iU+cdEBezbpM9d25oUmdvs= =9EOr -----END PGP SIGNATURE----- --=-qyEeAxUdC7OE8ukB1AkV--