From owner-svn-src-head@freebsd.org Mon Aug 21 13:49:43 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 71CCADDCAB1; Mon, 21 Aug 2017 13:49:43 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-it0-x235.google.com (mail-it0-x235.google.com [IPv6:2607:f8b0:4001:c0b::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3A12D70626; Mon, 21 Aug 2017 13:49:43 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-it0-x235.google.com with SMTP id 76so32685209ith.0; Mon, 21 Aug 2017 06:49:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=dqTROEsrc28jO2oUofNX9X5cvIXjG3vHOdCE7SUB8b4=; b=BJvjPnZ7NPlTdKaU4r9hsiNrRWV122F6TlHco90ViGxlpVpZtIvZ0P4RtwCmtsf1ar +yE5XZV7bvatK70hM/TIMLoGc2vF/3nMAofl7QVHBHlo64BvZ4nxBdzEWvXLJfjZex9L smzLr6yXGETrFrxQFFZKKJy6ymbuOCaa6vcjfVhaQsm8JZk6GB3O1YbfrIQWQ7/lgQkP tYJEcQuC+e3wdtAcJf0lQVlJ0SnBC2QP3gweG9zD70mdLoRL6CgNfMxClGJO7pJBzSYP jmbUQaJ1JFbu2vlPre4pJoBb/Up1CdsVXh2b8w3aI9f3qA1fOlx7DFG9biJWKFxfZ09x WDIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=dqTROEsrc28jO2oUofNX9X5cvIXjG3vHOdCE7SUB8b4=; b=B/yFkBcz0/oWseaMvZQmf44iBvPkFoASWnttcEqxw81SKiSiT+aXnAIULD4xRasbPf r1sAraECU9M7VTIA9H9XHfgcbHPvcF1UMLHMwQuhWbXr0vMYZIVmK9iGTP5dJDlc3d+n MEXct5P4T85fKkTddraOqC4KpS+BCug6xCsDllX7ius4ef9gy/FjroVMKxU7RHIfvF4P 5b7QJmL1TQPR5V5e1gEDAJTYIKbrkRBToQE43N9tP//cflSCp34W2N3PHQUYbw2/5CNj cFdvkN0k6baIUetGSmxwt5fx0RGIH7SsaEMh2Tb5NhiEWwgBwOgxRqWdHiJ8ItQNKTKm 8rgQ== X-Gm-Message-State: AHYfb5gCP0bh4WxU+SEeooZKP+zShMoFVBdtgBt11LF4BJgVn2imzN84 Y4sXGhDp30FL9T7ijPD+6kulRbj1Ng== X-Received: by 10.36.19.11 with SMTP id 11mr184741itz.153.1503323382597; Mon, 21 Aug 2017 06:49:42 -0700 (PDT) MIME-Version: 1.0 Sender: carpeddiem@gmail.com Received: by 10.107.24.66 with HTTP; Mon, 21 Aug 2017 06:49:22 -0700 (PDT) In-Reply-To: References: <201708190032.v7J0WQAa017551@repo.freebsd.org> From: Ed Maste Date: Mon, 21 Aug 2017 09:49:22 -0400 X-Google-Sender-Auth: 6FYH1XUVSxrT3vQMkYWXJT8F0vo Message-ID: Subject: Re: svn commit: r322678 - in head/usr.sbin/pw: . tests To: "Ngie Cooper (yaneurabeya)" Cc: src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Aug 2017 13:49:43 -0000 On 18 August 2017 at 21:08, Ngie Cooper (yaneurabeya) wrote: > >> On Aug 18, 2017, at 17:32, Ed Maste wrote: >> >> Author: emaste >> Date: Sat Aug 19 00:32:26 2017 >> New Revision: 322678 >> URL: https://svnweb.freebsd.org/changeset/base/322678 >> >> Log: >> pw useradd: Validate the user name before creating the entry >> >> Previouly it was possible to create users with spaces in the name with: >> pw useradd -u 1234 -g 1234 -n 'test user' >> >> The "-g 1234" is relevant, without it the name was already rejected >> as expected: ... > > Usernames with passwords are permitted in some cases, e.g., AD. I assume you meant "usernames with spaces"? Note that this change only addresses the discrepancy between "pw useradd 'test user'" (which was previously rejected) and "pw useradd 'test user' -g " (which was accepted prior to this change).